From: Avi Kivity <avi@qumranet.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] fix zero extending for mmio ld1/2/4 emulation in KVM
Date: Wed, 21 May 2008 10:05:14 +0000 [thread overview]
Message-ID: <4833F3DA.5090002@qumranet.com> (raw)
In-Reply-To: <4832A0A6.8050800@sgi.com>
Zhang, Xiantao wrote:
> Jes Sorensen wrote:
>
>> Matthew Chapman wrote:
>>
>>> Jes,
>>>
>>> Glad you tracked it down. Can I suggest rather than using memcpy, a
>>> more efficient way might be something like...
>>>
>>> #define ZERO_EXTEND(x,bits) ((x) & (~0UL >> (64-(bits))))
>>>
>>> *dest = ZERO_EXTEND(p->u.ioreq.data, 8*s);
>>>
>> Much nicer indeed!
>>
>> Here's a pretty version - Tony will you apply this one instead.
>>
> Hi, Jes
> Good catch!! Since this is a key fix for 2.6.26, Avi or Tony may
> help to push the fix into upstream. :-)
>
Applied, and also queued for 2.6.26.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-05-21 10:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 9:57 [patch] fix zero extending for mmio ld1/2/4 emulation in KVM Jes Sorensen
2008-05-20 10:33 ` Matthew Chapman
2008-05-20 11:13 ` Jes Sorensen
2008-05-21 9:46 ` Zhang, Xiantao
2008-05-21 10:05 ` Avi Kivity [this message]
2008-05-22 3:45 ` Isaku Yamahata
2008-05-22 8:08 ` Jes Sorensen
2008-05-22 15:16 ` Xu, Anthony
2008-05-22 15:23 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4833F3DA.5090002@qumranet.com \
--to=avi@qumranet.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox