From: Jay Lan <jlan@sgi.com>
To: "linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>
Cc: Simon Horman <horms@verge.net.au>,
"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: [PATCH] Reserve elfcorehdr memory in CONFIG_CRASH_DUMP
Date: Fri, 07 Nov 2008 02:32:32 +0000 [thread overview]
Message-ID: <4913A8C0.8090108@sgi.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
IA64 kdump kernel failed to initialize /proc/vmcore in 2.6.28-rc2.
A bug was introduced in this patch commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d9a9855d0b06ca6d6cc92596fedcc03f8512e062
The problem was that the call to reserve_elfcorehdr() should be placed
in CONFIG_CRASH_DUMP rather than in CONFIG_CRASH_KERNEL, which does
not exist.
The patch fixes the problem.
Signed-off-by: Jay Lan <jlan@sgi.com>
[-- Attachment #2: reserve-elfcorehdr-in-CRASH_DUMP --]
[-- Type: text/plain, Size: 545 bytes --]
---
arch/ia64/kernel/setup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/arch/ia64/kernel/setup.c
===================================================================
--- linux.orig/arch/ia64/kernel/setup.c 2008-11-06 18:01:18.000000000 -0800
+++ linux/arch/ia64/kernel/setup.c 2008-11-06 18:05:42.047332827 -0800
@@ -359,7 +359,7 @@ reserve_memory (void)
}
#endif
-#ifdef CONFIG_CRASH_KERNEL
+#ifdef CONFIG_CRASH_DUMP
if (reserve_elfcorehdr(&rsvd_region[n].start,
&rsvd_region[n].end) == 0)
n++;
next reply other threads:[~2008-11-07 2:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 2:32 Jay Lan [this message]
2008-11-07 2:49 ` [PATCH] Reserve elfcorehdr memory in CONFIG_CRASH_DUMP Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4913A8C0.8090108@sgi.com \
--to=jlan@sgi.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox