[PATCH] Reserve elfcorehdr memory in CONFIG_CRASH_DUMP

[PATCH] Reserve elfcorehdr memory in CONFIG_CRASH_DUMP

[Jay Lan]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

IA64 kdump kernel failed to initialize /proc/vmcore in 2.6.28-rc2.
A bug was introduced in this patch commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d9a9855d0b06ca6d6cc92596fedcc03f8512e062

The problem was that the call to reserve_elfcorehdr() should be placed
in CONFIG_CRASH_DUMP rather than in CONFIG_CRASH_KERNEL, which does
not exist.

The patch fixes the problem.

Signed-off-by: Jay Lan <jlan@sgi.com>

[-- Attachment #2: reserve-elfcorehdr-in-CRASH_DUMP --]
[-- Type: text/plain, Size: 545 bytes --]

---
 arch/ia64/kernel/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/arch/ia64/kernel/setup.c
===================================================================
--- linux.orig/arch/ia64/kernel/setup.c	2008-11-06 18:01:18.000000000 -0800
+++ linux/arch/ia64/kernel/setup.c	2008-11-06 18:05:42.047332827 -0800
@@ -359,7 +359,7 @@ reserve_memory (void)
 	}
 #endif
 
-#ifdef CONFIG_CRASH_KERNEL
+#ifdef CONFIG_CRASH_DUMP
 	if (reserve_elfcorehdr(&rsvd_region[n].start,
 			       &rsvd_region[n].end) == 0)
 		n++;

Re: [PATCH] Reserve elfcorehdr memory in CONFIG_CRASH_DUMP

[Simon Horman]

On Thu, Nov 06, 2008 at 06:32:32PM -0800, Jay Lan wrote:
> IA64 kdump kernel failed to initialize /proc/vmcore in 2.6.28-rc2.
> A bug was introduced in this patch commit:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;hÙa9855d0b06ca6d6cc92596fedcc03f8512e062
> 
> The problem was that the call to reserve_elfcorehdr() should be placed
> in CONFIG_CRASH_DUMP rather than in CONFIG_CRASH_KERNEL, which does
> not exist.
> 
> The patch fixes the problem.
> 
> Signed-off-by: Jay Lan <jlan@sgi.com>

Acked-by: Simon Horman <horms@verge.net.au>

> ---
>  arch/ia64/kernel/setup.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux/arch/ia64/kernel/setup.c
> =================================> --- linux.orig/arch/ia64/kernel/setup.c	2008-11-06 18:01:18.000000000 -0800
> +++ linux/arch/ia64/kernel/setup.c	2008-11-06 18:05:42.047332827 -0800
> @@ -359,7 +359,7 @@ reserve_memory (void)
>  	}
>  #endif
>  
> -#ifdef CONFIG_CRASH_KERNEL
> +#ifdef CONFIG_CRASH_DUMP
>  	if (reserve_elfcorehdr(&rsvd_region[n].start,
>  			       &rsvd_region[n].end) = 0)
>  		n++;


-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en