* [PATCH] ia64-kvm: fix sparse warnings
@ 2011-04-27 18:06 Jeff Mahoney
2011-04-28 0:26 ` Zhang, Xiantao
2011-04-28 9:36 ` Avi Kivity
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Mahoney @ 2011-04-27 18:06 UTC (permalink / raw)
To: linux-ia64
This patch fixes some sparse warning about "dubious one-bit signed bitfield."
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Originally-by: Jan Blunck <jblunck@suse.de>
Signed-off-by: Jan Blunck <jblunck@suse.de>
---
arch/ia64/kvm/vti.h | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
--- a/arch/ia64/kvm/vti.h
+++ b/arch/ia64/kvm/vti.h
@@ -83,13 +83,13 @@
union vac {
unsigned long value;
struct {
- int a_int:1;
- int a_from_int_cr:1;
- int a_to_int_cr:1;
- int a_from_psr:1;
- int a_from_cpuid:1;
- int a_cover:1;
- int a_bsw:1;
+ unsigned int a_int:1;
+ unsigned int a_from_int_cr:1;
+ unsigned int a_to_int_cr:1;
+ unsigned int a_from_psr:1;
+ unsigned int a_from_cpuid:1;
+ unsigned int a_cover:1;
+ unsigned int a_bsw:1;
long reserved:57;
};
};
@@ -97,12 +97,12 @@ union vac {
union vdc {
unsigned long value;
struct {
- int d_vmsw:1;
- int d_extint:1;
- int d_ibr_dbr:1;
- int d_pmc:1;
- int d_to_pmd:1;
- int d_itm:1;
+ unsigned int d_vmsw:1;
+ unsigned int d_extint:1;
+ unsigned int d_ibr_dbr:1;
+ unsigned int d_pmc:1;
+ unsigned int d_to_pmd:1;
+ unsigned int d_itm:1;
long reserved:58;
};
};
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] ia64-kvm: fix sparse warnings
2011-04-27 18:06 [PATCH] ia64-kvm: fix sparse warnings Jeff Mahoney
@ 2011-04-28 0:26 ` Zhang, Xiantao
2011-04-28 9:36 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Xiantao @ 2011-04-28 0:26 UTC (permalink / raw)
To: linux-ia64
Avi,
Can you take this patch to kvm.git ? Thanks!
Acked-by: Xiantao Zhang <xiantao.zhang@intel.com>
-----Original Message-----
From: Jeff Mahoney [mailto:jeffm@suse.com]
Sent: Thursday, April 28, 2011 2:06 AM
To: Zhang, Xiantao; Avi Kivity; Luck, Tony; Yu, Fenghua
Cc: linux-ia64@vger.kernel.org
Subject: [PATCH] ia64-kvm: fix sparse warnings
This patch fixes some sparse warning about "dubious one-bit signed bitfield."
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Originally-by: Jan Blunck <jblunck@suse.de>
Signed-off-by: Jan Blunck <jblunck@suse.de>
---
arch/ia64/kvm/vti.h | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
--- a/arch/ia64/kvm/vti.h
+++ b/arch/ia64/kvm/vti.h
@@ -83,13 +83,13 @@
union vac {
unsigned long value;
struct {
- int a_int:1;
- int a_from_int_cr:1;
- int a_to_int_cr:1;
- int a_from_psr:1;
- int a_from_cpuid:1;
- int a_cover:1;
- int a_bsw:1;
+ unsigned int a_int:1;
+ unsigned int a_from_int_cr:1;
+ unsigned int a_to_int_cr:1;
+ unsigned int a_from_psr:1;
+ unsigned int a_from_cpuid:1;
+ unsigned int a_cover:1;
+ unsigned int a_bsw:1;
long reserved:57;
};
};
@@ -97,12 +97,12 @@ union vac {
union vdc {
unsigned long value;
struct {
- int d_vmsw:1;
- int d_extint:1;
- int d_ibr_dbr:1;
- int d_pmc:1;
- int d_to_pmd:1;
- int d_itm:1;
+ unsigned int d_vmsw:1;
+ unsigned int d_extint:1;
+ unsigned int d_ibr_dbr:1;
+ unsigned int d_pmc:1;
+ unsigned int d_to_pmd:1;
+ unsigned int d_itm:1;
long reserved:58;
};
};
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ia64-kvm: fix sparse warnings
2011-04-27 18:06 [PATCH] ia64-kvm: fix sparse warnings Jeff Mahoney
2011-04-28 0:26 ` Zhang, Xiantao
@ 2011-04-28 9:36 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2011-04-28 9:36 UTC (permalink / raw)
To: linux-ia64
On 04/27/2011 09:06 PM, Jeff Mahoney wrote:
> This patch fixes some sparse warning about "dubious one-bit signed bitfield."
Thanks, applied.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-28 9:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-27 18:06 [PATCH] ia64-kvm: fix sparse warnings Jeff Mahoney
2011-04-28 0:26 ` Zhang, Xiantao
2011-04-28 9:36 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox