public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [IA64] Fix spinaphore down_spin()
@ 2010-06-29 22:13 Luck, Tony
  0 siblings, 0 replies; only message in thread
From: Luck, Tony @ 2010-06-29 22:13 UTC (permalink / raw)
  To: linux-ia64

Typo in down_spin() meant it only read the low 32 bits of the
"serve" value, instead of the full 64 bits. This results in the
system hanging when the values in ticket/serve get larger than
32-bits. A big enough system running the right test can hit this
in just a couple of days.

Reported via IRC by Bjorn Helgaas

Signed-off-by: Tony Luck <tony.luck@intel.com>

diff --git a/arch/ia64/mm/tlb.c b/arch/ia64/mm/tlb.c
index 5dfd916..7b3cdc6 100644
--- a/arch/ia64/mm/tlb.c
+++ b/arch/ia64/mm/tlb.c
@@ -121,7 +121,7 @@ static inline void down_spin(struct spinaphore *ss)
 	ia64_invala();
 
 	for (;;) {
-		asm volatile ("ld4.c.nc %0=[%1]" : "=r"(serve) : "r"(&ss->serve) : "memory");
+		asm volatile ("ld8.c.nc %0=[%1]" : "=r"(serve) : "r"(&ss->serve) : "memory");
 		if (time_before(t, serve))
 			return;
 		cpu_relax();

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-29 22:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-29 22:13 [IA64] Fix spinaphore down_spin() Luck, Tony

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox