From: "Toralf Förster" <toralf.foerster@gmx.de>
To: linux-ia64@vger.kernel.org
Subject: is sba_map_ioc_to_node() needed in arch/ia64/hp/common/sba_iommu.c
Date: Sun, 08 Jun 2014 13:56:35 +0000 [thread overview]
Message-ID: <53946B93.2070900@gmx.de> (raw)
I'm playing with cppcheck which complains about :
/* setup NUMA node association */
sba_map_ioc_to_node(ioc, device->handle);
return 0;<--- Memory leak: ioc
}
Well, cppcheck produces a fair amount of false positives, but in this
case I'm just wondering if there is really just one caller of the
function sba_map_ioc_to_node and furthermore if the function itself is
needed b/c its whole body is #ifdef'ed ? :
static void __init
sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle)
{
#ifdef CONFIG_NUMA
unsigned int node;
node = acpi_get_node(handle);
if (node != NUMA_NO_NODE && !node_online(node))
node = NUMA_NO_NODE;
ioc->node = node;
#endif
}
--
Toralf
reply other threads:[~2014-06-08 13:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53946B93.2070900@gmx.de \
--to=toralf.foerster@gmx.de \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox