* is sba_map_ioc_to_node() needed in arch/ia64/hp/common/sba_iommu.c
@ 2014-06-08 13:56 Toralf Förster
0 siblings, 0 replies; only message in thread
From: Toralf Förster @ 2014-06-08 13:56 UTC (permalink / raw)
To: linux-ia64
I'm playing with cppcheck which complains about :
/* setup NUMA node association */
sba_map_ioc_to_node(ioc, device->handle);
return 0;<--- Memory leak: ioc
}
Well, cppcheck produces a fair amount of false positives, but in this
case I'm just wondering if there is really just one caller of the
function sba_map_ioc_to_node and furthermore if the function itself is
needed b/c its whole body is #ifdef'ed ? :
static void __init
sba_map_ioc_to_node(struct ioc *ioc, acpi_handle handle)
{
#ifdef CONFIG_NUMA
unsigned int node;
node = acpi_get_node(handle);
if (node != NUMA_NO_NODE && !node_online(node))
node = NUMA_NO_NODE;
ioc->node = node;
#endif
}
--
Toralf
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-06-08 13:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-08 13:56 is sba_map_ioc_to_node() needed in arch/ia64/hp/common/sba_iommu.c Toralf Förster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox