From: Andrzej Hajda <a.hajda@samsung.com>
To: Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org
Subject: Re: [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation
Date: Wed, 16 Sep 2015 09:53:11 +0000 [thread overview]
Message-ID: <55F93C07.1050403@samsung.com> (raw)
In-Reply-To: <1438934377-4922-3-git-send-email-a.hajda@samsung.com>
Ping.
Regards
Andrzej
On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> arch/ia64/sn/pci/tioce_provider.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> index 46d3df4..2f13276 100644
> --- a/arch/ia64/sn/pci/tioce_provider.c
> +++ b/arch/ia64/sn/pci/tioce_provider.c
> @@ -1000,11 +1000,11 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
> * Allocate kernel bus soft and copy from prom.
> */
>
> - tioce_common = kzalloc(sizeof(struct tioce_common), GFP_KERNEL);
> + tioce_common = kmemdup(prom_bussoft, sizeof(struct tioce_common),
> + GFP_KERNEL);
> if (!tioce_common)
> return NULL;
>
> - memcpy(tioce_common, prom_bussoft, sizeof(struct tioce_common));
> tioce_common->ce_pcibus.bs_base = (unsigned long)
> ioremap(REGION_OFFSET(tioce_common->ce_pcibus.bs_base),
> sizeof(struct tioce_common));
prev parent reply other threads:[~2015-09-16 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438934377-4922-1-git-send-email-a.hajda@samsung.com>
2015-08-07 7:59 ` [PATCH 02/31] arch/ia64/tioce: use kmemdup rather than duplicating its implementation Andrzej Hajda
2015-09-16 9:53 ` Andrzej Hajda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F93C07.1050403@samsung.com \
--to=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox