public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch] fix HP simulator smp build replace __devinit -> __initdata
Date: Mon, 09 May 2005 07:24:16 +0000	[thread overview]
Message-ID: <6053.1115623456@kao2.melbourne.sgi.com> (raw)
In-Reply-To: <20050509065711.GI5692@cse.unsw.EDU.AU>

On Mon, 9 May 2005 16:57:11 +1000, 
Darren Williams <dsw@gelato.unsw.edu.au> wrote:
>Since we have updated the Autobuild system to use Cogito
>we can start to report and submit patches on the latest
>check-ins that break the build.
>
>Currently on the Gelato@UNSW Autobuild system:
>http://www.gelato.unsw.edu.au/kerncomp/
>we are seeing the sim_defconfig build fail, with the
>following error:
>
>arch/ia64/kernel/smpboot.c:627: error: mt_info causes a section type conflict
>
>the following non-git patch fixes the problem, tested
>on simulator, and zx1. I'm not sure why the simulator
>is triggering this build failure since zx1 sn2 are
>building OK?

__devinit is a no-op when CONFIG_HOTPLUG=y.  zx1 and sn2 configs enable
HOTPLUG, sim_defconfig does not.

>--- linux-2.6-orig/arch/ia64/kernel/smpboot.c	2005-05-09 16:25:09.000000000 +1000
>+++ linux-2.6-import/arch/ia64/kernel/smpboot.c	2005-05-09 15:53:15.000000000 +1000
>@@ -624,7 +624,7 @@ static struct {
> 	__u16   thread_id;
> 	__u16   proc_fixed_addr;
> 	__u8    valid;
>-}mt_info[NR_CPUS] __devinit;
>+}mt_info[NR_CPUS] __initdata;

That should be __devinitdata, not __initdata.


  reply	other threads:[~2005-05-09  7:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-09  6:57 [patch] fix HP simulator smp build replace __devinit -> __initdata Darren Williams
2005-05-09  7:24 ` Keith Owens [this message]
2005-05-09 11:21 ` [patch] fix HP simulator smp build replace __devinit -> __devinitdata (revised) Darren Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6053.1115623456@kao2.melbourne.sgi.com \
    --to=kaos@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox