* [patch] fix HP simulator smp build replace __devinit -> __initdata
@ 2005-05-09 6:57 Darren Williams
2005-05-09 7:24 ` Keith Owens
2005-05-09 11:21 ` [patch] fix HP simulator smp build replace __devinit -> __devinitdata (revised) Darren Williams
0 siblings, 2 replies; 3+ messages in thread
From: Darren Williams @ 2005-05-09 6:57 UTC (permalink / raw)
To: linux-ia64
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
Since we have updated the Autobuild system to use Cogito
we can start to report and submit patches on the latest
check-ins that break the build.
Currently on the Gelato@UNSW Autobuild system:
http://www.gelato.unsw.edu.au/kerncomp/
we are seeing the sim_defconfig build fail, with the
following error:
arch/ia64/kernel/smpboot.c:627: error: mt_info causes a section type conflict
the following non-git patch fixes the problem, tested
on simulator, and zx1. I'm not sure why the simulator
is triggering this build failure since zx1 sn2 are
building OK?
- dsw
--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------
[-- Attachment #2: smpboot.patch --]
[-- Type: text/plain, Size: 377 bytes --]
--- linux-2.6-orig/arch/ia64/kernel/smpboot.c 2005-05-09 16:25:09.000000000 +1000
+++ linux-2.6-import/arch/ia64/kernel/smpboot.c 2005-05-09 15:53:15.000000000 +1000
@@ -624,7 +624,7 @@ static struct {
__u16 thread_id;
__u16 proc_fixed_addr;
__u8 valid;
-}mt_info[NR_CPUS] __devinit;
+}mt_info[NR_CPUS] __initdata;
#ifdef CONFIG_HOTPLUG_CPU
static inline void
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] fix HP simulator smp build replace __devinit -> __initdata
2005-05-09 6:57 [patch] fix HP simulator smp build replace __devinit -> __initdata Darren Williams
@ 2005-05-09 7:24 ` Keith Owens
2005-05-09 11:21 ` [patch] fix HP simulator smp build replace __devinit -> __devinitdata (revised) Darren Williams
1 sibling, 0 replies; 3+ messages in thread
From: Keith Owens @ 2005-05-09 7:24 UTC (permalink / raw)
To: linux-ia64
On Mon, 9 May 2005 16:57:11 +1000,
Darren Williams <dsw@gelato.unsw.edu.au> wrote:
>Since we have updated the Autobuild system to use Cogito
>we can start to report and submit patches on the latest
>check-ins that break the build.
>
>Currently on the Gelato@UNSW Autobuild system:
>http://www.gelato.unsw.edu.au/kerncomp/
>we are seeing the sim_defconfig build fail, with the
>following error:
>
>arch/ia64/kernel/smpboot.c:627: error: mt_info causes a section type conflict
>
>the following non-git patch fixes the problem, tested
>on simulator, and zx1. I'm not sure why the simulator
>is triggering this build failure since zx1 sn2 are
>building OK?
__devinit is a no-op when CONFIG_HOTPLUG=y. zx1 and sn2 configs enable
HOTPLUG, sim_defconfig does not.
>--- linux-2.6-orig/arch/ia64/kernel/smpboot.c 2005-05-09 16:25:09.000000000 +1000
>+++ linux-2.6-import/arch/ia64/kernel/smpboot.c 2005-05-09 15:53:15.000000000 +1000
>@@ -624,7 +624,7 @@ static struct {
> __u16 thread_id;
> __u16 proc_fixed_addr;
> __u8 valid;
>-}mt_info[NR_CPUS] __devinit;
>+}mt_info[NR_CPUS] __initdata;
That should be __devinitdata, not __initdata.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] fix HP simulator smp build replace __devinit -> __devinitdata (revised)
2005-05-09 6:57 [patch] fix HP simulator smp build replace __devinit -> __initdata Darren Williams
2005-05-09 7:24 ` Keith Owens
@ 2005-05-09 11:21 ` Darren Williams
1 sibling, 0 replies; 3+ messages in thread
From: Darren Williams @ 2005-05-09 11:21 UTC (permalink / raw)
To: linux-ia64
[-- Attachment #1: Type: text/plain, Size: 1228 bytes --]
Hi Keith
On Mon, 09 May 2005, Keith Owens wrote:
> On Mon, 9 May 2005 16:57:11 +1000,
> Darren Williams <dsw@gelato.unsw.edu.au> wrote:
> >Since we have updated the Autobuild system to use Cogito
> >we can start to report and submit patches on the latest
> >check-ins that break the build.
> >
> >Currently on the Gelato@UNSW Autobuild system:
> >http://www.gelato.unsw.edu.au/kerncomp/
> >we are seeing the sim_defconfig build fail, with the
> >following error:
> >
> >arch/ia64/kernel/smpboot.c:627: error: mt_info causes a section type conflict
> >
> >the following non-git patch fixes the problem, tested
> >on simulator, and zx1. I'm not sure why the simulator
> >is triggering this build failure since zx1 sn2 are
> >building OK?
>
> __devinit is a no-op when CONFIG_HOTPLUG=y. zx1 and sn2 configs enable
> HOTPLUG, sim_defconfig does not.
>
>
> That should be __devinitdata, not __initdata.
Revised patch, thanks Keith
Tested for compile and boot on zx1 and simulator.
Signed-off-by: Darren Williams <dsw@gelato.unsw.edu.au>
--------------------------------------------------
Darren Williams <dsw AT gelato.unsw.edu.au>
Gelato@UNSW <www.gelato.unsw.edu.au>
--------------------------------------------------
[-- Attachment #2: smpboot.patch --]
[-- Type: text/plain, Size: 364 bytes --]
--- linux-2.6-orig/arch/ia64/kernel/smpboot.c 2005-05-09 16:29:30.000000000 +1000
+++ linux-2.6-import/arch/ia64/kernel/smpboot.c 2005-05-09 21:03:47.000000000 +1000
@@ -624,7 +624,7 @@
__u16 thread_id;
__u16 proc_fixed_addr;
__u8 valid;
-}mt_info[NR_CPUS] __devinit;
+}mt_info[NR_CPUS] __devinitdata;
#ifdef CONFIG_HOTPLUG_CPU
static inline void
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-05-09 11:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-09 6:57 [patch] fix HP simulator smp build replace __devinit -> __initdata Darren Williams
2005-05-09 7:24 ` Keith Owens
2005-05-09 11:21 ` [patch] fix HP simulator smp build replace __devinit -> __devinitdata (revised) Darren Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox