* [PATCH 2/2] simplify some condition checks
@ 2006-03-24 6:47 Satoru Takeuchi
2006-03-27 8:13 ` Satoru Takeuchi
0 siblings, 1 reply; 2+ messages in thread
From: Satoru Takeuchi @ 2006-03-24 6:47 UTC (permalink / raw)
To: linux-ia64
Some condition checks on iosapic_check_gsi_range() can be omitted
because always `base <= end' is assured. This patch simplifies that
ckecks.
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
---
arch/ia64/kernel/iosapic.c | 5 +----
1 files changed, 1 insertion(+), 4 deletions(-)
Index: linux-2.6.16/arch/ia64/kernel/iosapic.c
=================================--- linux-2.6.16.orig/arch/ia64/kernel/iosapic.c 2006-03-24 14:42:44.000000000 +0900
+++ linux-2.6.16/arch/ia64/kernel/iosapic.c 2006-03-24 14:42:55.000000000 +0900
@@ -994,10 +994,7 @@
base = iosapic_lists[index].gsi_base;
end = base + iosapic_lists[index].num_rte - 1;
- if (gsi_base < base && gsi_end < base)
- continue;/* OK */
-
- if (gsi_base > end && gsi_end > end)
+ if (gsi_end < base || end < gsi_base)
continue; /* OK */
return -EBUSY;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] simplify some condition checks
2006-03-24 6:47 [PATCH 2/2] simplify some condition checks Satoru Takeuchi
@ 2006-03-27 8:13 ` Satoru Takeuchi
0 siblings, 0 replies; 2+ messages in thread
From: Satoru Takeuchi @ 2006-03-27 8:13 UTC (permalink / raw)
To: linux-ia64
Some condition checks on iosapic_check_gsi_range() can be omitted
because always `base <= end' is assured. This patch simplifies that
ckecks.
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
---
arch/ia64/kernel/iosapic.c | 5 +----
1 files changed, 1 insertion(+), 4 deletions(-)
Index: linux-2.6.16/arch/ia64/kernel/iosapic.c
=================================--- linux-2.6.16.orig/arch/ia64/kernel/iosapic.c 2006-03-27 10:37:09.000000000 +0900
+++ linux-2.6.16/arch/ia64/kernel/iosapic.c 2006-03-27 15:13:08.000000000 +0900
@@ -1057,10 +1057,7 @@
base = iosapic_lists[index].gsi_base;
end = base + iosapic_lists[index].num_rte - 1;
- if (gsi_base < base && gsi_end < base)
- continue;/* OK */
-
- if (gsi_base > end && gsi_end > end)
+ if (gsi_end < base || end < gsi_base)
continue; /* OK */
return -EBUSY;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-27 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-24 6:47 [PATCH 2/2] simplify some condition checks Satoru Takeuchi
2006-03-27 8:13 ` Satoru Takeuchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox