* [PATCH] ia64: simplify esi object addition in Makefile
@ 2022-09-29 18:17 Masahiro Yamada
2022-09-29 19:44 ` Nicolas Schier
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2022-09-29 18:17 UTC (permalink / raw)
To: linux-kbuild; +Cc: linux-kernel, linux-ia64, Masahiro Yamada, Nicolas Schier
CONFIG_IA64_ESI is a bool option. I do not know why the Makefile was
written like this, but this should not have any functional change.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/ia64/kernel/Makefile | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/ia64/kernel/Makefile b/arch/ia64/kernel/Makefile
index 4a1fcb121dda..ae9ff07de4ab 100644
--- a/arch/ia64/kernel/Makefile
+++ b/arch/ia64/kernel/Makefile
@@ -34,10 +34,7 @@ mca_recovery-y += mca_drv.o mca_drv_asm.o
obj-$(CONFIG_IA64_MC_ERR_INJECT)+= err_inject.o
obj-$(CONFIG_STACKTRACE) += stacktrace.o
-obj-$(CONFIG_IA64_ESI) += esi.o
-ifneq ($(CONFIG_IA64_ESI),)
-obj-y += esi_stub.o # must be in kernel proper
-endif
+obj-$(CONFIG_IA64_ESI) += esi.o esi_stub.o # must be in kernel proper
obj-$(CONFIG_INTEL_IOMMU) += pci-dma.o
obj-$(CONFIG_ELF_CORE) += elfcore.o
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ia64: simplify esi object addition in Makefile
2022-09-29 18:17 [PATCH] ia64: simplify esi object addition in Makefile Masahiro Yamada
@ 2022-09-29 19:44 ` Nicolas Schier
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Schier @ 2022-09-29 19:44 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-kbuild, linux-kernel, linux-ia64
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
On Fri, Sep 30, 2022 at 03:17:15AM +0900, Masahiro Yamada wrote:
> CONFIG_IA64_ESI is a bool option. I do not know why the Makefile was
> written like this, but this should not have any functional change.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/ia64/kernel/Makefile | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/ia64/kernel/Makefile b/arch/ia64/kernel/Makefile
> index 4a1fcb121dda..ae9ff07de4ab 100644
> --- a/arch/ia64/kernel/Makefile
> +++ b/arch/ia64/kernel/Makefile
> @@ -34,10 +34,7 @@ mca_recovery-y += mca_drv.o mca_drv_asm.o
> obj-$(CONFIG_IA64_MC_ERR_INJECT)+= err_inject.o
> obj-$(CONFIG_STACKTRACE) += stacktrace.o
>
> -obj-$(CONFIG_IA64_ESI) += esi.o
> -ifneq ($(CONFIG_IA64_ESI),)
> -obj-y += esi_stub.o # must be in kernel proper
> -endif
> +obj-$(CONFIG_IA64_ESI) += esi.o esi_stub.o # must be in kernel proper
> obj-$(CONFIG_INTEL_IOMMU) += pci-dma.o
>
> obj-$(CONFIG_ELF_CORE) += elfcore.o
> --
> 2.34.1
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-29 19:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-29 18:17 [PATCH] ia64: simplify esi object addition in Makefile Masahiro Yamada
2022-09-29 19:44 ` Nicolas Schier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox