public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Aron Griffis <aron@hp.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH 3 of 3] Add /* never reached */ annotation
Date: Wed, 09 Jan 2008 03:29:38 +0000	[thread overview]
Message-ID: <bce918403f4c00fe3dfd.1199849378@jenkins.nashua> (raw)

1 file changed, 2 insertions(+), 2 deletions(-)
arch/ia64/kernel/efi.c |    4 ++--


As written, this loop could be for (;;) instead of do while (md).  The tests
inside the loop always result in a return so the loop never terminates normally.

Signed-off-by: Aron Griffis <aron@hp.com>

diff -r bc50f0946b69 -r bce918403f4c arch/ia64/kernel/efi.c
--- a/arch/ia64/kernel/efi.c	Tue Jan 08 22:29:33 2008 -0500
+++ b/arch/ia64/kernel/efi.c	Tue Jan 08 22:29:33 2008 -0500
@@ -762,7 +762,7 @@ efi_mem_attribute (unsigned long phys_ad
 		if (!md || (md->attribute & ~EFI_MEMORY_RUNTIME) != attr)
 			return 0;
 	} while (md);
-	return 0;
+	return 0;	/* never reached */
 }
 
 u64
@@ -798,7 +798,7 @@ kern_mem_attribute (unsigned long phys_a
 		if (!md || md->attribute != attr)
 			return 0;
 	} while (md);
-	return 0;
+	return 0;	/* never reached */
 }
 EXPORT_SYMBOL(kern_mem_attribute);
 



                 reply	other threads:[~2008-01-09  3:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bce918403f4c00fe3dfd.1199849378@jenkins.nashua \
    --to=aron@hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox