public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3 of 3] Add /* never reached */ annotation
@ 2008-01-09  3:29 Aron Griffis
  0 siblings, 0 replies; only message in thread
From: Aron Griffis @ 2008-01-09  3:29 UTC (permalink / raw)
  To: linux-ia64

1 file changed, 2 insertions(+), 2 deletions(-)
arch/ia64/kernel/efi.c |    4 ++--


As written, this loop could be for (;;) instead of do while (md).  The tests
inside the loop always result in a return so the loop never terminates normally.

Signed-off-by: Aron Griffis <aron@hp.com>

diff -r bc50f0946b69 -r bce918403f4c arch/ia64/kernel/efi.c
--- a/arch/ia64/kernel/efi.c	Tue Jan 08 22:29:33 2008 -0500
+++ b/arch/ia64/kernel/efi.c	Tue Jan 08 22:29:33 2008 -0500
@@ -762,7 +762,7 @@ efi_mem_attribute (unsigned long phys_ad
 		if (!md || (md->attribute & ~EFI_MEMORY_RUNTIME) != attr)
 			return 0;
 	} while (md);
-	return 0;
+	return 0;	/* never reached */
 }
 
 u64
@@ -798,7 +798,7 @@ kern_mem_attribute (unsigned long phys_a
 		if (!md || md->attribute != attr)
 			return 0;
 	} while (md);
-	return 0;
+	return 0;	/* never reached */
 }
 EXPORT_SYMBOL(kern_mem_attribute);
 



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-01-09  3:29 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-09  3:29 [PATCH 3 of 3] Add /* never reached */ annotation Aron Griffis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox