[PATCH] Fix SAL 3.2 detection

[PATCH] Fix SAL 3.2 detection

[Matthew Wilcox]

Hi David.  This important fix checks the SAl *revision* rather than
the *version*.  I carefully documented which was which, then used the
wrong one.

Index: arch/ia64/pci/pci.c
=================================RCS file: /var/cvs/linux-2.6/arch/ia64/pci/pci.c,v
retrieving revision 1.8
diff -u -p -r1.8 pci.c
--- a/arch/ia64/pci/pci.c	20 Mar 2004 20:29:23 -0000	1.8
+++ b/arch/ia64/pci/pci.c	24 Mar 2004 01:55:32 -0000
@@ -128,7 +128,8 @@ struct pci_raw_ops *raw_pci_ops = &pci_s
 static int __init
 pci_set_sal_ops (void)
 {
-	if (sal_version >= SAL_VERSION_CODE(3, 2)) {
+	if (sal_revision >= SAL_VERSION_CODE(3, 2)) {
+		printk("Using SAL 3.2 to access PCI config space\n");
 		raw_pci_ops = &pci_sal_ext_ops;
 	}
 	return 0;

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

Re: [PATCH] Fix SAL 3.2 detection

[Andreas Schwab]

Matthew Wilcox <willy@debian.org> writes:

> Hi David.  This important fix checks the SAl *revision* rather than
> the *version*.  I carefully documented which was which, then used the
> wrong one.

Thanks a lot, this has fixed all my issues!

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."