[patch 2/3] ia64: don't assume that unwcheck.py is executable

[patch 2/3] ia64: don't assume that unwcheck.py is executable

[akpm]

From: Andrew Morton <akpm@linux-foundation.org>

Don't assume that this file has execute permissions.  For example, patch(1)
loses that information.

Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: "Luck, Tony" <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/ia64/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable arch/ia64/Makefile
--- a/arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable
+++ a/arch/ia64/Makefile
@@ -77,7 +77,7 @@ vmlinux.gz: vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $@
 
 unwcheck: vmlinux
-	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
+	-$(Q)READELF=$(READELF) $(CONFIG_SHELL) $(srctree)/arch/ia64/scripts/unwcheck.py $<
 
 archclean:
 	$(Q)$(MAKE) $(clean)=$(boot)
_

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Andreas Schwab]

akpm@linux-foundation.org writes:

> diff -puN arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable arch/ia64/Makefile
> --- a/arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable
> +++ a/arch/ia64/Makefile
> @@ -77,7 +77,7 @@ vmlinux.gz: vmlinux
>  	$(Q)$(MAKE) $(build)=$(boot) $@
>  
>  unwcheck: vmlinux
> -	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> +	-$(Q)READELF=$(READELF) $(CONFIG_SHELL) $(srctree)/arch/ia64/scripts/unwcheck.py $<

unwcheck.py is not a shell script.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Andrew Morton]

On Thu, 06 Dec 2007 00:06:14 +0100
Andreas Schwab <schwab@suse.de> wrote:

> akpm@linux-foundation.org writes:
> 
> > diff -puN arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable arch/ia64/Makefile
> > --- a/arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable
> > +++ a/arch/ia64/Makefile
> > @@ -77,7 +77,7 @@ vmlinux.gz: vmlinux
> >  	$(Q)$(MAKE) $(build)=$(boot) $@
> >  
> >  unwcheck: vmlinux
> > -	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> > +	-$(Q)READELF=$(READELF) $(CONFIG_SHELL) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> 
> unwcheck.py is not a shell script.
> 

Oh well, whatever.  Please treat this as a bug report.

ie: someone please fix it.

RE: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Luck, Tony]

> Oh well, whatever.  Please treat this as a bug report.
>
> ie: someone please fix it.

Perhaps with?

-	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
+	-$(Q)READELF=$(READELF) python $(srctree)/arch/ia64/scripts/unwcheck.py $<

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Andrew Morton]

On Wed, 5 Dec 2007 15:25:46 -0800
"Luck, Tony" <tony.luck@intel.com> wrote:

> > Oh well, whatever.  Please treat this as a bug report.
> >
> > ie: someone please fix it.
> 
> Perhaps with?
> 
> -	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> +	-$(Q)READELF=$(READELF) python $(srctree)/arch/ia64/scripts/unwcheck.py $<

Spsoe so.  We get fancy with CONFIG_SHELL, but for flex/bison/gperf it
appears that kbuild just expects them to be present in $PATH.

Sam?

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Andreas Schwab]

Andrew Morton <akpm@linux-foundation.org> writes:

> On Thu, 06 Dec 2007 00:06:14 +0100
> Andreas Schwab <schwab@suse.de> wrote:
>
>> akpm@linux-foundation.org writes:
>> 
>> > diff -puN arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable arch/ia64/Makefile
>> > --- a/arch/ia64/Makefile~ia64-dont-assume-that-unwcheckpy-is-executable
>> > +++ a/arch/ia64/Makefile
>> > @@ -77,7 +77,7 @@ vmlinux.gz: vmlinux
>> >  	$(Q)$(MAKE) $(build)=$(boot) $@
>> >  
>> >  unwcheck: vmlinux
>> > -	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
>> > +	-$(Q)READELF=$(READELF) $(CONFIG_SHELL) $(srctree)/arch/ia64/scripts/unwcheck.py $<
>> 
>> unwcheck.py is not a shell script.
>> 
>
> Oh well, whatever.  Please treat this as a bug report.
>
> ie: someone please fix it.

s/$(CONFIG_SHELL)/python/

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Christoph Hellwig]

On Wed, Dec 05, 2007 at 03:17:33PM -0800, Andrew Morton wrote:
> > > -	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> > > +	-$(Q)READELF=$(READELF) $(CONFIG_SHELL) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> > 
> > unwcheck.py is not a shell script.
> > 
> 
> Oh well, whatever.  Please treat this as a bug report.
> 
> ie: someone please fix it.

Best would be to get rid of python.  Having another scripting language
as built requirement, and that only on ia64 doesn't sound like a
particularly good idea.

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Andrew Morton]

On Thu, 6 Dec 2007 07:45:57 +0000 Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Dec 05, 2007 at 03:17:33PM -0800, Andrew Morton wrote:
> > > > -	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> > > > +	-$(Q)READELF=$(READELF) $(CONFIG_SHELL) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> > > 
> > > unwcheck.py is not a shell script.
> > > 
> > 
> > Oh well, whatever.  Please treat this as a bug report.
> > 
> > ie: someone please fix it.
> 
> Best would be to get rid of python.  Having another scripting language
> as built requirement, and that only on ia64 doesn't sound like a
> particularly good idea.

It's probably not a big deal - especially as ia64 kernels are presuably not
as likely to be built in wild and whacky enviroments like some other
architectures.

afacit the script is optional anyway - it "check and verifies unwind info".
If python isn't available, just skip it..  

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Sam Ravnborg]

On Wed, Dec 05, 2007 at 03:25:46PM -0800, Luck, Tony wrote:
> > Oh well, whatever.  Please treat this as a bug report.
> >
> > ie: someone please fix it.
> 
> Perhaps with?
> 
> -	-$(Q)READELF=$(READELF) $(srctree)/arch/ia64/scripts/unwcheck.py $<
> +	-$(Q)READELF=$(READELF) python $(srctree)/arch/ia64/scripts/unwcheck.py $<

We do not have as much incompatibility among phython (or personal preference) than
we have for diver shells - so calling phython is fine.

That said I really do not like adding phython to the required tools even though
this is ia64 specific.
This script was previously written in perl wich is more widely used.
What was the exact reason switching to phython and can we do the same in perl?

	Sam

RE: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Luck, Tony]

> What was the exact reason switching to phython and can we do the same in perl?

It was a shell script (using awk) before it was pythonised. The
motivation was correct functionality when cross-building on a
32-bit host.  Here's the commit:

 http://tinyurl.com/28hmoc

-Tony

Re: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Sam Ravnborg]

On Thu, Dec 06, 2007 at 02:05:15PM -0800, Luck, Tony wrote:
> > What was the exact reason switching to phython and can we do the same in perl?
> 
> It was a shell script (using awk) before it was pythonised. The
> motivation was correct functionality when cross-building on a
> 32-bit host.  Here's the commit:
> 
>  http://tinyurl.com/28hmoc

If you read the comments in the phyton file is says:
+# Based on a shell/awk script originally written by Harish Patil,
+# which was converted to Perl by Matthew Chapman, which was converted
+# to Python by David Mosberger.

So somewhere a perl variant has existed.

	Sam

RE: [patch 2/3] ia64: don't assume that unwcheck.py is executable

[Luck, Tony]

> So somewhere a perl variant has existed.

This mail thread http://tinyurl.com/2vuacw points to the perl
version.  But it doesn't appear to have ever been checked into
the tree (and the mail message says that it also suffers from
the not-working for a 64-bit binary when running on a 32-bit
host issue ... though it claims that it would be easy to fix).

I can't actually see the script because the web server at unsw.edu.au
seems to feel that it should execute the perl script rather than show
me the contents of it :-(

-Tony

P.S. The python version was checked in almost four years ago ... perhaps
it isn't too big of a deal that we are using it.