Missing include in hugetlbpage.c

Missing include in hugetlbpage.c

[Andreas Schwab]

This fixes a missing include file in arch/ia64/mm/hugetlbpage.c in 2.6.5.

Andreas.

--- linux-2.6.5/arch/ia64/mm/hugetlbpage.c.~1~	2004-04-05 14:56:14.085179196 +0200
+++ linux-2.6.5/arch/ia64/mm/hugetlbpage.c	2004-04-05 15:06:44.868178163 +0200
@@ -9,6 +9,7 @@
  */
 
 #include <linux/config.h>
+#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/fs.h>
 #include <linux/mm.h>

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

RE: Missing include in hugetlbpage.c

[Chen, Kenneth W]

>>>> Andreas Schwab wrote on Mon, April 05, 2004 7:01 AM
>
> This fixes a missing include file in arch/ia64/mm/hugetlbpage.c in 2.6.5.
>
> @@ -9,6 +9,7 @@
>   */
>
>  #include <linux/config.h>
> +#include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/fs.h>
>  #include <linux/mm.h>

Just wondering what part depends on that header file, hugetlbpage can't
be module anyway.

- Ken

Re: Missing include in hugetlbpage.c

[Andreas Schwab]

"Chen, Kenneth W" <kenneth.w.chen@intel.com> writes:

>>>>> Andreas Schwab wrote on Mon, April 05, 2004 7:01 AM
>>
>> This fixes a missing include file in arch/ia64/mm/hugetlbpage.c in 2.6.5.
>>
>> @@ -9,6 +9,7 @@
>>   */
>>
>>  #include <linux/config.h>
>> +#include <linux/module.h>
>>  #include <linux/init.h>
>>  #include <linux/fs.h>
>>  #include <linux/mm.h>
>
> Just wondering what part depends on that header file, hugetlbpage can't
> be module anyway.

This has nothing to do with being module or not.  EXPORT_SYMBOL also needs
it.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Missing include in hugetlbpage.c

[David Mosberger]

>>>>> On Mon, 05 Apr 2004 18:56:45 +0200, Andreas Schwab <schwab@suse.de> said:

  Andreas> This has nothing to do with being module or not.
  Andreas> EXPORT_SYMBOL also needs it.

But I don't see any EXPORT_SYMBOL in hugetlbpage.c.  What am I missing?

	--david

Re: Missing include in hugetlbpage.c

[Andreas Schwab]

David Mosberger <davidm@napali.hpl.hp.com> writes:

>>>>>> On Mon, 05 Apr 2004 18:56:45 +0200, Andreas Schwab <schwab@suse.de> said:
>
>   Andreas> This has nothing to do with being module or not.
>   Andreas> EXPORT_SYMBOL also needs it.
>
> But I don't see any EXPORT_SYMBOL in hugetlbpage.c.  What am I missing?

http://linux.bkbits.net:8080/linux-2.5/cset%401.1772?nav=index.html|ChangeSet@-3d

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."