[Linux-ia64] [PATCH] fix casting problem in megaraid driver

[Linux-ia64] [PATCH] fix casting problem in megaraid driver

[aip]

[-- Attachment #1.1: Type: text/plain, Size: 90 bytes --]

This patch fixes bug where mbox's pointer was cast to integer, caused
segfault.

-Andrew


[-- Attachment #1.2: linux-2.4.0test7-ia64-megaraid.patch --]
[-- Type: application/x-patch, Size: 1575 bytes --]

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

[Linux-ia64] [PATCH] fix casting problem in megaraid driver

[aip]

[-- Attachment #1: Type: text/plain, Size: 90 bytes --]


This patch fixes bug where mbox's pointer was cast to integer, caused
segfault.

-Andrew

[-- Attachment #2: linux-2.4.0test7-ia64-megaraid.patch --]
[-- Type: application/x-patch, Size: 1543 bytes --]

Re: [Linux-ia64] [PATCH] fix casting problem in megaraid driver

[David Mosberger]

Hi Andrew,

>>>>> On Tue, 5 Sep 2000 10:50:38 -0700, aip@turbolinux.com said:

  Andrew> This patch fixes bug where mbox's pointer was cast to
  Andrew> integer, caused segfault.

The patch looks a bit suspicious to me.  I'm not familiar with the
megaraid driver, but looking at the relevant code, it's clear that
"paddr" really is a 32 bit PCI address (it gets written to the device
as a sequence of four byte writes), so changing it to u64 clearly
isn't 100% correct.

Now, looking at the code that calls the routine in question:

 mega_register_mailbox (megaCfg, virt_to_bus ((void *) &megaCfg->mailbox64));

we find that, yuck, this is another driver that hasn't been updated
for the PCI DMA interface.  Not much point in hacking around in this
driver until this gets rectified...

Note that the virt_to_bus() and bus_to_virt() macros have been
obsoleted by the PCI DMA interface and will be removed from the kernel
at some future point (I'm tempted to do this now so we'll discover
right away which drivers need cleaning up).

Can you ask the megaraid maintainers to update their driver to use the
PCI DMA interface?

	--david

RE: [Linux-ia64] [PATCH] fix casting problem in megaraid driver

[Matt_Domsch]

> we find that, yuck, this is another driver that hasn't been updated
> for the PCI DMA interface.  Not much point in hacking around in this
> driver until this gets rectified...
> 
> Note that the virt_to_bus() and bus_to_virt() macros have been
> obsoleted by the PCI DMA interface and will be removed from the kernel
> at some future point (I'm tempted to do this now so we'll discover
> right away which drivers need cleaning up).
> 
> Can you ask the megaraid maintainers to update their driver to use the
> PCI DMA interface?
> 
> 	--david

The update is in progress at AMI already.

Thanks,
Matt