public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: David Mosberger <davidm@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] /proc/pid/mem and stack variables
Date: Thu, 18 Jan 2001 02:48:11 +0000	[thread overview]
Message-ID: <marc-linux-ia64-105590693005074@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590693005037@msgid-missing>

>>>>> On Mon, 15 Jan 2001 18:57:56 +0100 (MET), Erich Focht <focht@ess.nec.de> said:

  Erich> A small patch for the file fs/proc/base.c implementing llseek for
  Erich> /proc/PID/mem is appended. It's the same as for /dev/kmem therefore it
  Erich> does only SEEK_SET and SEEK_CUR, not SEEK_END. 

Thanks for the patch, I applied it to my tree and will work on getting
it into Linus's tree.

  Erich> It works for reading from stack pages, positioning is ok but the return
  Erich> value is -1 (which is wrong). Probably because the offsets seem to be
  Erich> negative... Can anybody please tell me why I'm getting the -1 error return
  Erich> though I should get back the huge negative offset?

I added a force_successful_syscall_return() to ensure that a succesful
lseek() returning a "negative" value isn't mistaken as an error.  I
did the same to memory_lseek() in drivers/char/mem.c.  This should
avoid the problem you were seeing.

	--david


      parent reply	other threads:[~2001-01-18  2:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-12 16:20 [Linux-ia64] /proc/pid/mem and stack variables Maciej Golebiewski
2001-01-12 18:45 ` Pete Wyckoff
2001-01-13  2:29 ` David Mosberger
2001-01-15 10:17 ` Maciej Golebiewski
2001-01-15 17:57 ` Erich Focht
2001-01-18  2:48 ` David Mosberger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=marc-linux-ia64-105590693005074@msgid-missing \
    --to=davidm@hpl.hp.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox