[Linux-ia64] null pointer in iosapic_pci_fixup()

[Linux-ia64] null pointer in iosapic_pci_fixup()

[Xavier Bru]

When a device is found behind a pci/pci bridge and this device has no
IRQ decribed in the ACPI table, Linux prints a warning  message: 
" PCI: Couldn't map irq for (...)"
unfortunately there is a null "bridge" pointer at that point. This makes the
system hang in release 2.4.9 and have a wrong print of bus , device
and irq in kernel 2.4.13.

A posssible patch could be:

--- linux-2.4.13-ori/arch/ia64/kernel/iosapic.c	Mon Nov 26 17:09:49 2001
+++ linux-2.4.13-new/arch/ia64/kernel/iosapic.c	Mon Nov 26 16:42:40 2001
@@ -615,8 +615,8 @@
 					       pin, vector);
 				else
 					printk(KERN_WARNING
-					       "PCI: Couldn't map irq for (B%d,I%d,P%d)o\n",
-					       bridge->bus->number, PCI_SLOT(bridge->devfn),
+					       "PCI: Couldn't map irq for (B%d,I%d,P%d)\n",
+					       dev->bus->number, PCI_SLOT(dev->devfn),
 					       pin);
 			}
 			if (vector >= 0) {

-- 

 Sincères salutations.
_____________________________________________________________________
 
Xavier BRU                 BULL ISD/R&D/INTEL office:     FREC B1-422
tel : +33 (0)4 76 29 77 45                    http://www-frec.bull.fr
fax : +33 (0)4 76 29 77 70                 mailto:Xavier.Bru@bull.net
addr: BULL, 1 rue de Provence, BP 208, 38432 Echirolles Cedex, FRANCE
_____________________________________________________________________

Re: [Linux-ia64] null pointer in iosapic_pci_fixup()

[David Mosberger]

>>>>> On Mon, 26 Nov 2001 17:17:26 +0100 (NFT), Xavier Bru  <Xavier.Bru@bull.net> said:

  Xavier> When a device is found behind a pci/pci bridge and this
  Xavier> device has no IRQ decribed in the ACPI table, Linux prints a
  Xavier> warning message: " PCI: Couldn't map irq for (...)"
  Xavier> unfortunately there is a null "bridge" pointer at that
  Xavier> point. This makes the system hang in release 2.4.9 and have
  Xavier> a wrong print of bus , device and irq in kernel 2.4.13.

The previous printk() seems to suffer from the same bug.  I changed
both of them.

Thanks,

	--david