[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

[Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]


   I was testing w/ some disks that appear to have bad partition
tables and was getting the following error messages:

SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
 sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
  Use GNU Parted to correct disk.

Unfortunately, that's not where the problem stopped.  I got
random pointer dereference problems, and was apparently having
data structures freed out from under them.  Turns out the
find_valid_gpt() was freeing data structures more than once and
passing back pointers to freed structures.  Patch below.

	Alex

--
Alex Williamson                                  Linux Development Lab
alex_williamson@hp.com                                 Hewlett Packard
970-898-9173                                          Fort Collins, CO

[-- Attachment #2: efi.diff --]
[-- Type: text/plain, Size: 692 bytes --]

--- linux/fs/partitions/efi.c~	25 Jan 2002 20:15:06 -0000	1.2
+++ linux/fs/partitions/efi.c	14 Feb 2002 16:50:07 -0000
@@ -549,10 +549,14 @@ find_valid_gpt(struct gendisk *hd, struc
 
 		*gpt = pgpt;
 		*ptes = pptes;
-		if (agpt)
+		if (agpt) {
 			kfree(agpt);
-		if (aptes)
+			agpt = NULL;
+		}
+		if (aptes) {
 			kfree(aptes);
+			aptes = NULL;
+		}
 	} /* if primary is valid */
 	else {
 		/* Primary GPT is bad, check the Alternate GPT */
@@ -602,6 +606,8 @@ find_valid_gpt(struct gendisk *hd, struc
 	/* Both primary and alternate GPTs are bad, and/or PMBR is invalid.
 	 * This isn't our disk, return 0.
 	 */
+	*gpt = *ptes = NULL;
+
 	if (pgpt) {
 		kfree(pgpt);
 		pgpt = NULL;

RE: [Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Matt_Domsch]

> I got random pointer dereference problems, and was apparently having
> data structures freed out from under them.  Turns out the
> find_valid_gpt() was freeing data structures more than once and
> passing back pointers to freed structures.  Patch below.

Mia culpa.  Pass the brown paper bag.  Thanks for the fix.
-Matt

--
Matt Domsch
Sr. Software Engineer
Dell Linux Solutions www.dell.com/linux
#1 US Linux Server provider with 24.5% (IDC Dec 2001)
#2 Worldwide Linux Server provider with 18.2% (IDC Dec 2001)

Re: [Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[William Lee Irwin III]

On Thu, Feb 14, 2002 at 10:11:19AM -0700, Alex Williamson wrote:
>    I was testing w/ some disks that appear to have bad partition
> tables and was getting the following error messages:
> SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
>  sdt:<4>  Warning: Disk has a valid GPT signature but invalid PMBR.
>   Use GNU Parted to correct disk.
> Unfortunately, that's not where the problem stopped.  I got
> random pointer dereference problems, and was apparently having
> data structures freed out from under them.  Turns out the
> find_valid_gpt() was freeing data structures more than once and
> passing back pointers to freed structures.  Patch below.

Is it just me or is this getting resent every couple of hours?
... something has gone horribly wrong.

Cheers,
Bill

Re: [Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[Alex Williamson]

On Fri, 2002-02-15 at 07:30, William Lee Irwin III wrote:
> 
> Is it just me or is this getting resent every couple of hours?
> ... something has gone horribly wrong.
> 

   Yes it has, and I apologize.  I wish it was a machine close enough
that I could just yank the LAN tap, but unfortunately it's on the
other side of the HP network.  Seems that a combination of a poorly
configured HP server and a slow sourceforge mail server are having
just enough trouble talking that the mail gets through but the
acknowledgement gets dropped.  What was that about pass the brown
paper bag?  Sorry folks, I'll try to get the message killed ASAP.
Thanks,

	Alex

Re: [Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[David Mosberger]

>>>>> On Thu, 14 Feb 2002 10:11:19 -0700, Alex Williamson <alex_williamson@hp.com> said:

  Alex>    I was testing w/ some disks that appear to have bad
  Alex> partition tables and was getting the following error messages:

  Alex> SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
  Alex> sdt:<4> Warning: Disk has a valid GPT signature but invalid
  Alex> PMBR.  Use GNU Parted to correct disk.

  Alex> Unfortunately, that's not where the problem stopped.  I got
  Alex> random pointer dereference problems, and was apparently having
  Alex> data structures freed out from under them.  Turns out the
  Alex> find_valid_gpt() was freeing data structures more than once
  Alex> and passing back pointers to freed structures.  Patch below.

Applied, thanks!

	--david

Re: [Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[John Hesterberg]

On Fri, Feb 15, 2002 at 12:00:31PM -0800, David Mosberger wrote:
> >>>>> On Thu, 14 Feb 2002 10:11:19 -0700, Alex Williamson <alex_williamson@hp.com> said:
> 
>   Alex>    I was testing w/ some disks that appear to have bad
>   Alex> partition tables and was getting the following error messages:
> 
>   Alex> SCSI device sdt: 35566480 512-byte hdwr sectors (18210 MB)
>   Alex> sdt:<4> Warning: Disk has a valid GPT signature but invalid
>   Alex> PMBR.  Use GNU Parted to correct disk.
> 
>   Alex> Unfortunately, that's not where the problem stopped.  I got
>   Alex> random pointer dereference problems, and was apparently having
>   Alex> data structures freed out from under them.  Turns out the
>   Alex> find_valid_gpt() was freeing data structures more than once
>   Alex> and passing back pointers to freed structures.  Patch below.
> 
> Applied, thanks!
> 
> 	--david

So the key to getting things applied to keep sending the exact same
message over and over and over?  

:-)

John

Re: [Linux-ia64] [PATCH] linux/fs/partitions/efi.c error handling

[David Mosberger]

>>>>> On Fri, 15 Feb 2002 18:46:14 -0600, John Hesterberg <jh@sgi.com> said:

  John> So the key to getting things applied to keep sending the exact
  John> same message over and over and over?

  John> :-)

Actually, I saw Alex's mail only once.  If you use procmail, I highly
recommend adding the following rule near the top of your .procmailrc:

# suppress duplicate mails (e.g., mail sent to multiple mailing lists)
:0 Wh: msgid.lock
| formail -D 32768 mail/msgid.cache

This keeps off all those annoying replicants when cc'd both explicitly
and on mailing-lists.

	--david