From: David Mosberger <davidm@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] null pointer dereference patch
Date: Wed, 20 Feb 2002 22:26:35 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590701905154@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590698806040@msgid-missing>
>>>>> On Wed, 20 Feb 2002 11:22:29 +1100, Keith Owens <kaos@ocs.com.au> said:
Keith> On Tue, 12 Feb 2002 14:09:43 -0800, David Mosberger
Keith> <davidm@hpl.hp.com> wrote:
>>>>>>> On Tue, 12 Feb 2002 14:51:22 -0700, Bjorn Helgaas
>>>>>>> <bjorn_helgaas@hp.com> said:
>>
Bjorn> Without the attached patch, unaligned references before
Bjorn> init_modules() is called result in null pointer dereferences.
Bjorn> This is against 2.4.17-ia64-011226.
>> I wonder whether module_list shouldn't be made to be NULL until
>> init_modules() has had a chance to initialize it. Keith?
Keith> Some arch dependent init code relies on extable working right
Keith> from the start, to catch kernel operations that may or may
Keith> not be valid, depending on the precise hardware. Changing
Keith> module_list to NULL breaks that code, the patch is correct.
If you insist on the kernel module descriptor being initialized right
from the get go, then I'd argue there should be a way for statically
initializing this descriptor. I really think it's a bad idea to have
partially initialized data laying around.
--david
next prev parent reply other threads:[~2002-02-20 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-12 21:51 [Linux-ia64] null pointer dereference patch Bjorn Helgaas
2002-02-12 22:09 ` David Mosberger
2002-02-20 0:22 ` Keith Owens
2002-02-20 22:26 ` David Mosberger [this message]
2002-02-20 22:47 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590701905154@msgid-missing \
--to=davidm@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox