From: Keith Owens <kaos@ocs.com.au>
To: linux-ia64@vger.kernel.org
Subject: Re: [Linux-ia64] null pointer dereference patch
Date: Wed, 20 Feb 2002 22:47:03 +0000 [thread overview]
Message-ID: <marc-linux-ia64-105590701905155@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-105590698806040@msgid-missing>
On Wed, 20 Feb 2002 14:26:35 -0800,
David Mosberger <davidm@hpl.hp.com> wrote:
>>>>>> On Wed, 20 Feb 2002 11:22:29 +1100, Keith Owens <kaos@ocs.com.au> said:
> Keith> Some arch dependent init code relies on extable working right
> Keith> from the start, to catch kernel operations that may or may
> Keith> not be valid, depending on the precise hardware. Changing
> Keith> module_list to NULL breaks that code, the patch is correct.
>
>If you insist on the kernel module descriptor being initialized right
>from the get go, then I'd argue there should be a way for statically
>initializing this descriptor. I really think it's a bad idea to have
>partially initialized data laying around.
The bulk of the kernel module descriptor is statically initialized,
all the common fields are filled in that way, including the extable
that init code relies on. However archdata is a bit harder (arch
dependent initialization) and the kernel_data field cannot be
statically initialized at all. Just have to check if those fields have
been filled in or not. In any case it is possible (but unlikely) for a
module to be loaded that has no archdata so the field can be NULL for
modules as well.
prev parent reply other threads:[~2002-02-20 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-12 21:51 [Linux-ia64] null pointer dereference patch Bjorn Helgaas
2002-02-12 22:09 ` David Mosberger
2002-02-20 0:22 ` Keith Owens
2002-02-20 22:26 ` David Mosberger
2002-02-20 22:47 ` Keith Owens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-105590701905155@msgid-missing \
--to=kaos@ocs.com.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox