[Linux-ia64] [PATCH] make xconfig broken in ia64-020622

[Linux-ia64] [PATCH] make xconfig broken in ia64-020622

[Khalid Aziz]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

020622 version of ia64 patch breaks "make xconfig". This is due to a bug
in sound drivers configuration file. Attached patch fixes this problem.

--
Khalid 

====================================================================
Khalid Aziz                                   Linux Systems Division
(970)898-9214                                        Hewlett-Packard
khalid@fc.hp.com                                    Fort Collins, CO

[-- Attachment #2: patch.sound --]
[-- Type: text/plain, Size: 581 bytes --]

--- linux-2.4.18-ia64-020622/drivers/sound/Config.in	Mon Jul  8 15:57:30 2002
+++ linux-2.4.18-ia64-020622-fixed/drivers/sound/Config.in	Mon Jul  8 15:58:43 2002
@@ -30,7 +30,7 @@
 	fi
     fi
 fi
-dep_tristate '  FM801' CONFIG_FM801 
+dep_tristate '  FM801' CONFIG_FM801 $CONFIG_SOUND $CONFIG_PCI
 dep_tristate '  Creative SBLive! (EMU10K1)' CONFIG_SOUND_EMU10K1 $CONFIG_SOUND $CONFIG_PCI
 dep_mbool    '    Creative SBLive! MIDI' CONFIG_MIDI_EMU10K1 $CONFIG_SOUND_EMU10K1 $CONFIG_EXPERIMENTAL
 dep_tristate '  Crystal SoundFusion (CS4280/461x)' CONFIG_SOUND_FUSION $CONFIG_SOUND

RE: [Linux-ia64] [PATCH] make xconfig broken in ia64-020622

[Xavier Bru]

Unfortunatly, there are more things broken with make xconfig:

. multiple conditions are not handled by tkparse:

eg: unable to set CONFIG_IA64_MCA when CONFIG_IA64_DIG is set.

if [ "$CONFIG_IA64_GENERIC" = "y" ] || [ "$CONFIG_IA64_DIG" = "y" ] \
   || [ "$CONFIG_IA64_HP_ZX1" = "y" ]; then
	bool '  Enable IA-64 Machine Check Abort' CONFIG_IA64_MCA
	define_bool CONFIG_PM y
fi

. block device options are not generated in 2.4.18:

ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_LOOP).
ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_NBD).
ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_RAM).
Having a look in tkparse.c, we can read:
" * TO DO:
 * - xconfig is at the end of its life cycle.  Contact <mec@shout.net> if
 *   you are interested in working on the replacement."

I think that the linux hackers probably use make menuconfig, as they
did not report such problems :-) ???
Xavier

Re: [Linux-ia64] [PATCH] make xconfig broken in ia64-020622

[Khalid Aziz]

Absolutely. xconfig parser has major problems with the following patch
to arch/ia64/config.in in 020622:

+else # ! HP_SIM
+mainmenu_option next_comment
+comment 'Block devices'
+tristate 'Loopback device support' CONFIG_BLK_DEV_LOOP
+dep_tristate 'Network block device support' CONFIG_BLK_DEV_NBD
$CONFIG_NET
+
+tristate 'RAM disk support' CONFIG_BLK_DEV_RAM
+if [ "$CONFIG_BLK_DEV_RAM" = "y" -o "$CONFIG_BLK_DEV_RAM" = "m" ]; then
+   int '  Default RAM disk size' CONFIG_BLK_DEV_RAM_SIZE 4096
+fi
+endmenu

xconfig parser looks at this definition of 'Block devices' and the one
in drivers/block/Config.in and considers them duplicates inspite of the
conditional. With this patch, you can not configure loopback device or
RAM disk unless you are configuring for HP Simulator.

Without the patch I sent, "make xconfig" won't even start. So this patch
only makes xconfig atleast partially usable.

--
Khalid

Xavier Bru wrote:
> 
> Unfortunatly, there are more things broken with make xconfig:
> 
> . multiple conditions are not handled by tkparse:
> 
> eg: unable to set CONFIG_IA64_MCA when CONFIG_IA64_DIG is set.
> 
> if [ "$CONFIG_IA64_GENERIC" = "y" ] || [ "$CONFIG_IA64_DIG" = "y" ] \
>    || [ "$CONFIG_IA64_HP_ZX1" = "y" ]; then
>         bool '  Enable IA-64 Machine Check Abort' CONFIG_IA64_MCA
>         define_bool CONFIG_PM y
> fi
> 
> . block device options are not generated in 2.4.18:
> 
> ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_LOOP).
> ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_NBD).
> ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_RAM).
> Having a look in tkparse.c, we can read:
> " * TO DO:
>  * - xconfig is at the end of its life cycle.  Contact <mec@shout.net> if
>  *   you are interested in working on the replacement."
> 
> I think that the linux hackers probably use make menuconfig, as they
> did not report such problems :-) ???
> Xavier
> 
> _______________________________________________
> Linux-IA64 mailing list
> Linux-IA64@linuxia64.org
> http://lists.linuxia64.org/lists/listinfo/linux-ia64

==================================
Khalid Aziz                                   Linux Systems Division
(970)898-9214                                        Hewlett-Packard
khalid@fc.hp.com                                    Fort Collins, CO

Re: [Linux-ia64] [PATCH] make xconfig broken in ia64-020622

[David Mosberger]

>>>>> On Wed, 10 Jul 2002 11:05:19 -0600, Khalid Aziz <khalid@fc.hp.com> said:

  Khalid> Absolutely. xconfig parser has major problems with the
  Khalid> following patch to arch/ia64/config.in in 020622:

  Khalid> +else # ! HP_SIM
  Khalid> +mainmenu_option next_comment
  Khalid> +comment 'Block devices'
  Khalid> +tristate 'Loopback device support' CONFIG_BLK_DEV_LOOP
  Khalid> +dep_tristate 'Network block device support' CONFIG_BLK_DEV_NBD
  Khalid> $CONFIG_NET
  Khalid> +
  Khalid> +tristate 'RAM disk support' CONFIG_BLK_DEV_RAM
  Khalid> +if [ "$CONFIG_BLK_DEV_RAM" = "y" -o "$CONFIG_BLK_DEV_RAM" = "m" ]; then
  Khalid> +   int '  Default RAM disk size' CONFIG_BLK_DEV_RAM_SIZE 4096
  Khalid> +fi
  Khalid> +endmenu

  Khalid> xconfig parser looks at this definition of 'Block devices'
  Khalid> and the one in drivers/block/Config.in and considers them
  Khalid> duplicates inspite of the conditional. With this patch, you
  Khalid> can not configure loopback device or RAM disk unless you are
  Khalid> configuring for HP Simulator.

  Khalid> Without the patch I sent, "make xconfig" won't even
  Khalid> start. So this patch only makes xconfig atleast partially
  Khalid> usable.

If nobody wants to fix this problem, perhaps what we should do is
change "make xconfig" so it just prints a message telling the user to
do "make menuconfig" instead.  Other suggestions (and particular patches)
are welcome...

	--david

Re: [Linux-ia64] [PATCH] make xconfig broken in ia64-020622

[Khalid Aziz]

David Mosberger wrote:
> 
> 
> If nobody wants to fix this problem, perhaps what we should do is
> change "make xconfig" so it just prints a message telling the user to
> do "make menuconfig" instead.  Other suggestions (and particular patches)
> are welcome...

It might not be a bad idea to do this anyway until xconfig is fixed. If
xconfig never gets fixed, the message to use menuconfig will stay in
permanently.

-- 
Khalid

==================================
Khalid Aziz                                   Linux Systems Division
(970)898-9214                                        Hewlett-Packard
khalid@fc.hp.com                                    Fort Collins, CO

Re: [Linux-ia64] [PATCH] make xconfig broken in ia64-020622

[Keith Owens]

On Wed, 10 Jul 2002 18:06:03 +0200 (DFT), 
Xavier Bru <Xavier.Bru@bull.net> wrote:
>Unfortunatly, there are more things broken with make xconfig:
>
>. multiple conditions are not handled by tkparse:
>
>eg: unable to set CONFIG_IA64_MCA when CONFIG_IA64_DIG is set.
>
>if [ "$CONFIG_IA64_GENERIC" = "y" ] || [ "$CONFIG_IA64_DIG" = "y" ] \
>   || [ "$CONFIG_IA64_HP_ZX1" = "y" ]; then
>	bool '  Enable IA-64 Machine Check Abort' CONFIG_IA64_MCA
>	define_bool CONFIG_PM y
>fi
>
>. block device options are not generated in 2.4.18:
>
>ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_LOOP).
>ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_NBD).
>ERROR - Attempting to write value for unconfigured variable (CONFIG_BLK_DEV_RAM).

Documentation/kbuild/config-language.txt: Config Language is not 'bash'.

Index: 18.95/arch/ia64/config.in
--- 18.95/arch/ia64/config.in Thu, 09 May 2002 12:00:25 +1000 kaos (linux-2.4/s/c/38_config.in 1.1.2.1.2.2.3.1.1.6 644)
+++ 18.95(w)/arch/ia64/config.in Fri, 19 Jul 2002 16:38:02 +1000 kaos (linux-2.4/s/c/38_config.in 1.1.2.1.2.2.3.1.1.6 644)
@@ -78,13 +78,12 @@ if [ "$CONFIG_MCKINLEY" = "y" ]; then
 	fi
 fi
 
-if [ "$CONFIG_IA64_GENERIC" = "y" ] || [ "$CONFIG_IA64_DIG" = "y" ] \
-   || [ "$CONFIG_IA64_HP_ZX1" = "y" ]; then
+if [ "$CONFIG_IA64_GENERIC" = "y" -o "$CONFIG_IA64_DIG" = "y" -o "$CONFIG_IA64_HP_ZX1" = "y" ]; then
 	bool '  Enable IA-64 Machine Check Abort' CONFIG_IA64_MCA
 	define_bool CONFIG_PM y
 fi
 
-if [ "$CONFIG_IA64_SGI_SN1" = "y" ] || [ "$CONFIG_IA64_SGI_SN2" = "y" ]; then
+if [ "$CONFIG_IA64_SGI_SN1" = "y" -o "$CONFIG_IA64_SGI_SN2" = "y" ]; then
 	define_bool CONFIG_IA64_SGI_SN y
 	bool '  Enable extra debugging code' CONFIG_IA64_SGI_SN_DEBUG n
 	bool '  Enable SGI Medusa Simulator Support' CONFIG_IA64_SGI_SN_SIM
@@ -143,6 +142,10 @@ fi
 
 if [ "$CONFIG_IA64_HP_SIM" = "n" ]; then
 
+define_tristate CONFIG_BLK_DEV_LOOP n
+define_tristate CONFIG_BLK_DEV_NBD n
+define_tristate CONFIG_BLK_DEV_RAM n
+
 source drivers/mtd/Config.in
 source drivers/pnp/Config.in
 source drivers/block/Config.in