public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [Linux-ia64] CPU hotplug boot change for IA64
@ 2002-08-02 21:22 Kimio Suganuma
  0 siblings, 0 replies; only message in thread
From: Kimio Suganuma @ 2002-08-02 21:22 UTC (permalink / raw)
  To: linux-ia64

[-- Attachment #1: Type: text/plain, Size: 1092 bytes --]

Hi David, Rusty,

I attached a CPU hotplug boot change patch for IA-64
against 2.5.29 + David's IA64 patch. Please include this in
the next release.

I've just tested it on a 2way Bigsur but it should work on
the other systems.

In this patch, I added initial value of cpu_online_map as following,

 /* Bitmask of currently online CPUs */
-volatile unsigned long cpu_online_map;
+volatile unsigned long cpu_online_map = 1;
 unsigned long phys_cpu_present_map;

Bit for CPU#0 on cpu_online_map was set at smp_boot_cpus() before.
But on the 2.5.29, place of calling smp_boot_cpus() is changed to
later timing and this seems to make a chance that smp_call_function()
is called before setting cpu_online_map, (I guess.)
In that case, smp_call_function won't return because num_online_cpus()
returns 0 and the system will hang.

I have an experience of this problem only on a large system
like Tiger, but it may occur on another system.

Rusty, I guess this modification should be needed for i386, too.

I'd appreciate any comment.

Thanks,
Kimi

-- 
Kimio Suganuma <k-suganuma@mvj.biglobe.ne.jp>

[-- Attachment #2: hotplug-boot-change-ia64.patch.gz --]
[-- Type: application/octet-stream, Size: 2670 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-08-02 21:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-08-02 21:22 [Linux-ia64] CPU hotplug boot change for IA64 Kimio Suganuma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox