[Linux-ia64] Problem with 2.4.19 and ACPI

[Linux-ia64] Problem with 2.4.19 and ACPI

[Xavier Bru]

Hi,
We found a problem booting 2.4.19 on our IA64 platform.
The new code for ACPI gets the hosts bus address space from ACPI calling
acpi_get_crs_addr(). 
On Bull platform, we have a specific bus that accesses the chipset,
and provides no memory range. This should not be a problem, as
acpi_get_crs_addr() scans the resources of the bus and returns if no
memory range.
Unfortunately, the detection of the end of resources loops on the
ACPI_RSTYPE_END_TAG item due to a wrong size provided in this item,
and sytem does not boot.

Platform boots OK with the following patch:
-----------------------------------------------------------------------------
diff --exclude-from /home/xb/proc/diff.exclude -aur 2.4.19.ref/drivers/acpi/resources/rsmisc.c 2.4.19/drivers/acpi/resources/rsmiscc.c
--- 2.4.19.ref/drivers/acpi/resources/rsmisc.c	Mon Aug 26 14:01:04 2002
+++ 2.4.19/drivers/acpi/resources/rsmisc.c	Wed Sep 18 16:42:32 2002
@@ -79,7 +79,7 @@
 	/*
 	 * Set the Length parameter
 	 */
-	output_struct->length = 0;
+	output_struct->length = (u32) struct_size; /*BULL*/
 
 	/*
 	 * Return the final size of the structure

Traces ------------------------------------------------
0xe00000000440d2a0 acpi_get_crs_next <---- loop
        args (0xe00000001eaffc50, 0xe00000001eaffc40)
        kernel .text 0xe000000004400000 0xe00000000440d2a0 0xe00000000440d320
0xe00000000440d450 acpi_get_crs_addr+0x50
        args (0xe00000001eaffc50, 0x0, 0xe00000001eaffc60, 0xe00000001eaffc68, 0xe00000001eaffc70)
        kernel .text 0xe000000004400000 0xe00000000440d400 0xe00000000440d600
0xe00000000440d6b0 acpi_get_addr_space+0xb0
        args (0x0, 0x0, 0xe00000001eaffc60, 0xe00000001eaffc68, 0xe00000001eaffc70)
        kernel .text 0xe000000004400000 0xe00000000440d600 0xe00000000440d700
0xe000000004443ef0 pcibios_scan_root+0x90
        args (0xe00000001ea61030, 0xe00000001ea77f00, 0xff, 0xe00000001eaffc70, 0xe00000000466cac0)
        kernel .text 0xe000000004400000 0xe000000004443e60 0xe000000004443f40
0xe00000000466cac0 acpi_pci_root_add+0x400
        args (0xe00000001eaa5e00, 0xe00000001ea77e8a, 0xe00000001ea77e80, 0xe00000001ea77e88, 0xe00000001eaa5e5a)
        kernel .text 0xe000000004400000 0xe00000000466c6c0 0xe00000000466cc40
0xe00000000466a0a0 acpi_bus_driver_init+0x160
        args (0xe00000001eaa5e00, 0xe000000004c681e8, 0xe000000004ecfb30, 0x309, 0xe00000000466aae0)
        kernel .text 0xe000000004400000 0xe000000004669f40 0xe00000000466a2e0
0xe00000000466aae0 acpi_bus_find_driver+0x1a0
        args (0xe00000001eaa5e00, 0xe000000004c681e8, 0xe000000004c680b8, 0xffffffffffffffed, 0xe00000000466bf30)
        kernel .text 0xe000000004400000 0xe00000000466a940 0xe00000000466aba0
0xe00000000466bf30 acpi_bus_add+0xc70


0xe00000001eaffc50 00000058 00000000 1ea63100 e0000000   X........1¦....à

0xe00000001ea63100 0000000b 00000048 00000002 00000000   ....H........... 
0xe00000001ea63110 00000000 00000001 00000001 00000000   ................
0xe00000001ea63120 00000000 000000ff 000000ff 00000000   ....ÿ...ÿ.......
0xe00000001ea63130 00000001 00000000 00000000 00000000   ................
0xe00000001ea63140 00000000 00000000 00000007 00000000
                                              XXXXXXXX length=0
0xe00000001ea63150 00000000 00000000 00000000 00000000   ................
0xe00000001ea63160 eaeaeaea eaeaeaea 00000000 00000000   êêêêêêêê........
0xe00000001ea63170 00000000 00000000 00000000 00000000   ................

-- 

 Sincères salutations.
_____________________________________________________________________
 
Xavier BRU                 BULL ISD/R&D/INTEL office:     FREC B1-422
tel : +33 (0)4 76 29 77 45                    http://www-frec.bull.fr
fax : +33 (0)4 76 29 77 70                 mailto:Xavier.Bru@bull.net
addr: BULL, 1 rue de Provence, BP 208, 38432 Echirolles Cedex, FRANCE
_____________________________________________________________________

Re: [Linux-ia64] Problem with 2.4.19 and ACPI

[Bjorn Helgaas]

> Unfortunately, the detection of the end of resources loops on the
> ACPI_RSTYPE_END_TAG item due to a wrong size provided in this item,
> and sytem does not boot.

Can you try Takayoshi's patch
(https://external-lists.vasoftware.com/archives//linux-ia64/2002-August/003889.html)
instead?  That changes acpi_get_crs_addr() to bail out when it
sees an ACPI_RSTYPE_END_TAG, so we shouldn't care about the
size.

Bjorn

Re: [Linux-ia64] Problem with 2.4.19 and ACPI

[Xavier Bru]

Takayoshi's patch is OK for us.

Thanks

Xavier

Bjorn Helgaas writes:
 > > Unfortunately, the detection of the end of resources loops on the
 > > ACPI_RSTYPE_END_TAG item due to a wrong size provided in this item,
 > > and sytem does not boot.
 > 
 > Can you try Takayoshi's patch
 > (https://external-lists.vasoftware.com/archives//linux-ia64/2002-August/003889.html)
 > instead?  That changes acpi_get_crs_addr() to bail out when it
 > sees an ACPI_RSTYPE_END_TAG, so we shouldn't care about the
 > size.
 > 
 > Bjorn
 >