public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
* [Linux-ia64] [Patch] Fix in printk.c
@ 2003-01-18  1:15 Siddha, Suresh B
  0 siblings, 0 replies; only message in thread
From: Siddha, Suresh B @ 2003-01-18  1:15 UTC (permalink / raw)
  To: linux-ia64

[-- Attachment #1: Type: text/plain, Size: 816 bytes --]

c99 specifies

<snip>
       [#7] If, within a  translation  unit,  the  same  identifier
       appears   with  both  internal  and  external  linkage,  the
       behavior is undefined.
</snip>

"early_printk" has this type of behaviour in printk.c. Attached/appended patch removes the dependency on the behaviour of the compiler.

thanks,
suresh

diff -Nru linux-2.5.52/kernel/printk.c~ linux-2.5.52/kernel/printk.c
--- linux-2.5.52/kernel/printk.c~	Fri Jan 17 14:53:30 2003
+++ linux-2.5.52/kernel/printk.c	Fri Jan 17 14:53:37 2003
@@ -329,7 +329,7 @@
 	}
 #ifdef CONFIG_IA64_EARLY_PRINTK
 	if (!console_drivers) {
-		static void early_printk (const char *str, size_t len);
+		void early_printk (const char *str, size_t len);
 		early_printk(&LOG_BUF(start), end - start);
 	}
 #endif


[-- Attachment #2: printk.c.diff --]
[-- Type: application/octet-stream, Size: 451 bytes --]

diff -Nru linux-2.5.52/kernel/printk.c~ linux-2.5.52/kernel/printk.c
--- linux-2.5.52/kernel/printk.c~	Fri Jan 17 14:53:30 2003
+++ linux-2.5.52/kernel/printk.c	Fri Jan 17 14:53:37 2003
@@ -329,7 +329,7 @@
 	}
 #ifdef CONFIG_IA64_EARLY_PRINTK
 	if (!console_drivers) {
-		static void early_printk (const char *str, size_t len);
+		void early_printk (const char *str, size_t len);
 		early_printk(&LOG_BUF(start), end - start);
 	}
 #endif

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-01-18  1:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-01-18  1:15 [Linux-ia64] [Patch] Fix in printk.c Siddha, Suresh B

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox