[Linux-ia64] bogus __clear_bit macro

[Linux-ia64] bogus __clear_bit macro

[Chen, Kenneth W]

David,

It looks like when __clear_bit() was implemented, the deletion of the macro falls through the crack.  This macro prohibit the actual __clear_bit to be invoked.

--- include/asm-ia64/bitops.h-	Tue Mar  4 19:29:35 2003
+++ include/asm-ia64/bitops.h	Tue Mar 11 10:49:36 2003
@@ -450,8 +450,6 @@
 
 #ifdef __KERNEL__
 
-#define __clear_bit(nr, addr)        clear_bit(nr, addr)
-
 #define ext2_set_bit                 test_and_set_bit
 #define ext2_clear_bit               test_and_clear_bit
 #define ext2_test_bit                test_bit

[Linux-ia64] bogus __clear_bit macro

[Peter Chubb]

>>>>> "Kenneth" = Kenneth W Chen <Chen> writes:

Kenneth> David,
Kenneth> It looks like when __clear_bit() was implemented, the deletion of the macro falls through the crack.  This macro prohibit the actual __clear_bit to be invoked.


While you're fixing bitops.h, making test_bit take a const qualified
arg will kill some warnings in reiserfs...

--- /tmp/geta24522      2003-03-12 09:19:31.000000000 +1100
+++ linux/include/asm-ia64/bitops.h    2003-03-12 09:17:53.000000000 +1100
@@ -275,7 +275,7 @@
 }

 static __inline__ int
-test_bit (int nr, volatile void *addr)
+test_bit (int nr, const volatile void *addr)
 {
	return 1 & (((const volatile __u32 *) addr)[nr >> 5] >> (nr & 31));
 }