[Linux-ia64] show_trace_task portability

[Linux-ia64] show_trace_task portability

[Vladimir Simonov]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

Hi!
Trying to port some patches from i386 to ia64 I've found that
show_trace_task is the only portable way to show tasks' call
traces(perhaps because it is called from ./kernel/sched.c:)).
But its ia64 implementation can't work with running task.

Attached patch fixes this issue.

As I understand show_trace and show_stack are platform
dependent or have different sense/args.

Any opinion?

Best regards
Vladimir Simonov


[-- Attachment #2: diff-show_trace_task.ia64 --]
[-- Type: text/plain, Size: 335 bytes --]

--- linux.orig/arch/ia64/kernel/process.c	Fri Mar 21 08:32:37 2003
+++ linux/arch/ia64/kernel/process.c		Fri Mar 21 08:53:06 2003
@@ -53,10 +53,7 @@
 void
 show_trace_task (struct task_struct *task)
 {
-	struct unw_frame_info info;
-
-	unw_init_from_blocked_task(&info, task);
-	do_show_stack(&info, 0);
+	show_stack(task);
 }
 
 void

Re: [Linux-ia64] show_trace_task portability

[David Mosberger]

Hi Vladimir,

>>>>> On Fri, 21 Mar 2003 12:36:23 +0300, Vladimir Simonov <sv@sw.com.sg> said:

  Vladimir> Hi!  Trying to port some patches from i386 to ia64 I've
  Vladimir> found that show_trace_task is the only portable way to
  Vladimir> show tasks' call traces(perhaps because it is called from
  Vladimir> ./kernel/sched.c:)).  But its ia64 implementation can't
  Vladimir> work with running task.

  Vladimir> Attached patch fixes this issue.

  Vladimir> As I understand show_trace and show_stack are platform
  Vladimir> dependent or have different sense/args.

  Vladimir> Any opinion?

The patch looks fine to me.  I applied it in the 2.5 tree.

Thanks,

	--david

Re: [Linux-ia64] show_trace_task portability

[Bjorn Helgaas]

On Friday 21 March 2003 2:36 am, Vladimir Simonov wrote:
> Hi!
> Trying to port some patches from i386 to ia64 I've found that
> show_trace_task is the only portable way to show tasks' call
> traces(perhaps because it is called from ./kernel/sched.c:)).
> But its ia64 implementation can't work with running task.
> 
> Attached patch fixes this issue.

I applied this for 2.4.

Bjorn