local symbols in discarded section

local symbols in discarded section

[Luck, Tony]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]


>   Tony> undefined reference to `local symbols in discarded 
> section .exit.text'
> 
>   Tony> message.  Is this related to the warning about using 
> an old linker?
> 
> Not likely.  It sounds like a driver is failing to use __exit_p() (see
> linux/init.h).

The offending driver is i460-agp.c.  Patch attached.

-Tony

[-- Attachment #2: i460-agp.patch --]
[-- Type: application/octet-stream, Size: 441 bytes --]

===== drivers/char/agp/i460-agp.c 1.26 vs edited =====
--- 1.26/drivers/char/agp/i460-agp.c	Mon Jun 16 18:55:34 2003
+++ edited/drivers/char/agp/i460-agp.c	Thu Jun 19 13:28:28 2003
@@ -608,7 +608,7 @@
 	.name		= "agpgart-intel-i460",
 	.id_table	= agp_intel_i460_pci_table,
 	.probe		= agp_intel_i460_probe,
-	.remove		= agp_intel_i460_remove,
+	.remove		= __exit_p(agp_intel_i460_remove),
 };
 
 static int __init agp_intel_i460_init(void)

Re: local symbols in discarded section

[David Mosberger]

>>>>> On Thu, 19 Jun 2003 13:34:55 -0700, "Luck, Tony" <tony.luck@intel.com> said:

  Tony> undefined reference to `local symbols in discarded
  >> section .exit.text'

  Tony> message.  Is this related to the warning about using
  >> an old linker?

  >> Not likely.  It sounds like a driver is failing to use __exit_p()
  >> (see linux/init.h).

  Tony> The offending driver is i460-agp.c.  Patch attached.

Applied, thanks.

	--david