From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] sn2 module (& other misc.) fixes
Date: Mon, 04 Aug 2003 21:54:23 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106003411719237@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106003174416756@msgid-missing>
On Mon, Aug 04, 2003 at 02:14:04PM -0700, Jesse Barnes wrote:
> nasid_t master_baseio_nasid = INVALID_NASID; /* This is the master base I/O nasid */
> +EXPORT_SYMBOL(master_nasid);
why is this exported?
> int num_base_io_scsi_ctlr = 2; /* used by syssgi */
> vertex_hdl_t base_io_scsi_ctlr_vhdl[NUM_BASE_IO_SCSI_CTLR];
> +EXPORT_SYMBOL(base_io_scsi_ctlr_vhdl);
Why do you want this export. Or rather why does this tasteless stuff
exist at all? (And the comment looks wrong, too..)
> partid_t sn_partid = -1;
> +EXPORT_SYMBOL(sn_partid);
> +
> char sn_system_serial_number_string[128];
> u64 sn_partition_serial_number;
> +EXPORT_SYMBOL(sn_system_serial_number_string);
> +EXPORT_SYMBOL(sn_partition_serial_number);
>
> short physical_node_map[MAX_PHYSNODE_ID];
> +EXPORT_SYMBOL(physical_node_map);
Again, what is all this for?
next prev parent reply other threads:[~2003-08-04 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-04 21:14 [PATCH] sn2 module (& other misc.) fixes Jesse Barnes
2003-08-04 21:54 ` Christoph Hellwig [this message]
2003-08-04 22:01 ` Jesse Barnes
2003-08-04 22:04 ` Christoph Hellwig
2003-08-04 23:31 ` David Mosberger
2003-08-05 0:06 ` Jesse Barnes
2003-08-05 1:01 ` David Mosberger
2003-08-05 1:15 ` Jesse Barnes
2003-08-05 6:04 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106003411719237@msgid-missing \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox