From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: arch/ia64/hp/common/sba_iommu.c should include version.h
Date: Mon, 08 Sep 2003 18:26:08 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106304582419413@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106298384827966@msgid-missing>
--text follows this line--
Ian> As it uses version macros.
Ian> This fix allows Linus bk tree to build.
I think the proper fix here is to remove the #ifdef alltogether.
Version-checks inside the main-line kernel are generally frowned upon.
Unless somebody objects, I'll make that change.
--david
Ian> === arch/ia64/hp/common/sba_iommu.c 1.29 vs edited == Ian> --- 1.29/arch/ia64/hp/common/sba_iommu.c Mon Sep 1 09:14:08 2003
Ian> +++ edited/arch/ia64/hp/common/sba_iommu.c Mon Sep 8 11:02:04 2003
Ian> @@ -33,6 +33,7 @@
Ian> #include <linux/seq_file.h>
Ian> #include <linux/acpi.h>
Ian> #include <linux/efi.h>
Ian> +#include <linux/version.h>
Ian> #include <asm/delay.h> /* ia64_get_itc() */
Ian> #include <asm/io.h>
Ian> --text follows this line--
prev parent reply other threads:[~2003-09-08 18:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-08 1:17 arch/ia64/hp/common/sba_iommu.c should include version.h Ian Wienand
2003-09-08 18:26 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106304582419413@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox