* arch/ia64/hp/common/sba_iommu.c should include version.h
@ 2003-09-08 1:17 Ian Wienand
2003-09-08 18:26 ` David Mosberger
0 siblings, 1 reply; 2+ messages in thread
From: Ian Wienand @ 2003-09-08 1:17 UTC (permalink / raw)
To: linux-ia64
[-- Attachment #1: Type: text/plain, Size: 130 bytes --]
As it uses version macros.
This fix allows Linus bk tree to build.
-i
ianw@gelato.unsw.edu.au
http://www.gelato.unsw.edu.au
[-- Attachment #2: sba_iommu.c.diff --]
[-- Type: text/plain, Size: 386 bytes --]
===== arch/ia64/hp/common/sba_iommu.c 1.29 vs edited =====
--- 1.29/arch/ia64/hp/common/sba_iommu.c Mon Sep 1 09:14:08 2003
+++ edited/arch/ia64/hp/common/sba_iommu.c Mon Sep 8 11:02:04 2003
@@ -33,6 +33,7 @@
#include <linux/seq_file.h>
#include <linux/acpi.h>
#include <linux/efi.h>
+#include <linux/version.h>
#include <asm/delay.h> /* ia64_get_itc() */
#include <asm/io.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: arch/ia64/hp/common/sba_iommu.c should include version.h
2003-09-08 1:17 arch/ia64/hp/common/sba_iommu.c should include version.h Ian Wienand
@ 2003-09-08 18:26 ` David Mosberger
0 siblings, 0 replies; 2+ messages in thread
From: David Mosberger @ 2003-09-08 18:26 UTC (permalink / raw)
To: linux-ia64
--text follows this line--
Ian> As it uses version macros.
Ian> This fix allows Linus bk tree to build.
I think the proper fix here is to remove the #ifdef alltogether.
Version-checks inside the main-line kernel are generally frowned upon.
Unless somebody objects, I'll make that change.
--david
Ian> === arch/ia64/hp/common/sba_iommu.c 1.29 vs edited == Ian> --- 1.29/arch/ia64/hp/common/sba_iommu.c Mon Sep 1 09:14:08 2003
Ian> +++ edited/arch/ia64/hp/common/sba_iommu.c Mon Sep 8 11:02:04 2003
Ian> @@ -33,6 +33,7 @@
Ian> #include <linux/seq_file.h>
Ian> #include <linux/acpi.h>
Ian> #include <linux/efi.h>
Ian> +#include <linux/version.h>
Ian> #include <asm/delay.h> /* ia64_get_itc() */
Ian> #include <asm/io.h>
Ian> --text follows this line--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-09-08 18:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-08 1:17 arch/ia64/hp/common/sba_iommu.c should include version.h Ian Wienand
2003-09-08 18:26 ` David Mosberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox