* Re: [PATCH] kill sn_ksyms.c
2003-09-25 19:54 [PATCH] kill sn_ksyms.c Christoph Hellwig
@ 2003-10-05 16:33 ` Jes Sorensen
2003-10-05 20:47 ` Jesse Barnes
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jes Sorensen @ 2003-10-05 16:33 UTC (permalink / raw)
To: linux-ia64
>>>>> "Christoph" = Christoph Hellwig <hch@lst.de> writes:
Christoph> None of the exported symbols is referenced by a module,
Christoph> even more the file doesn't compile shen
Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.
There are some device drivers coming that will depend on some of these
symbols so I'd prefer to keep this file in place, at least for
now. And yes, said drivers are GPL'ed.
Jes
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kill sn_ksyms.c
2003-09-25 19:54 [PATCH] kill sn_ksyms.c Christoph Hellwig
2003-10-05 16:33 ` Jes Sorensen
@ 2003-10-05 20:47 ` Jesse Barnes
2003-10-06 12:19 ` Christoph Hellwig
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Jesse Barnes @ 2003-10-05 20:47 UTC (permalink / raw)
To: linux-ia64
On Sun, Oct 05, 2003 at 12:33:00PM -0400, Jes Sorensen wrote:
> >>>>> "Christoph" = Christoph Hellwig <hch@lst.de> writes:
>
> Christoph> None of the exported symbols is referenced by a module,
> Christoph> even more the file doesn't compile shen
> Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.
>
> There are some device drivers coming that will depend on some of these
> symbols so I'd prefer to keep this file in place, at least for
> now. And yes, said drivers are GPL'ed.
Or just move that stuff when we submit the drivers. I think Robin
looked at this a bit...
Jesse
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kill sn_ksyms.c
2003-09-25 19:54 [PATCH] kill sn_ksyms.c Christoph Hellwig
2003-10-05 16:33 ` Jes Sorensen
2003-10-05 20:47 ` Jesse Barnes
@ 2003-10-06 12:19 ` Christoph Hellwig
2003-10-06 18:18 ` Robin Holt
2003-10-07 8:09 ` Christoph Hellwig
4 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2003-10-06 12:19 UTC (permalink / raw)
To: linux-ia64
On Sun, Oct 05, 2003 at 12:33:00PM -0400, Jes Sorensen wrote:
> >>>>> "Christoph" = Christoph Hellwig <hch@lst.de> writes:
>
> Christoph> None of the exported symbols is referenced by a module,
> Christoph> even more the file doesn't compile shen
> Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.
>
> There are some device drivers coming that will depend on some of these
> symbols so I'd prefer to keep this file in place, at least for
> now. And yes, said drivers are GPL'ed.
Most of that stuff isn't even used by ioc4 or fetchop and *ksyms.c are
on their way out. Add new exports to the files defining the symbols
when a new drivers needs them.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] kill sn_ksyms.c
2003-09-25 19:54 [PATCH] kill sn_ksyms.c Christoph Hellwig
` (2 preceding siblings ...)
2003-10-06 12:19 ` Christoph Hellwig
@ 2003-10-06 18:18 ` Robin Holt
2003-10-07 8:09 ` Christoph Hellwig
4 siblings, 0 replies; 6+ messages in thread
From: Robin Holt @ 2003-10-06 18:18 UTC (permalink / raw)
To: linux-ia64
On Sun, Oct 05, 2003 at 01:47:05PM -0700, Jesse Barnes wrote:
> On Sun, Oct 05, 2003 at 12:33:00PM -0400, Jes Sorensen wrote:
> > >>>>> "Christoph" = Christoph Hellwig <hch@lst.de> writes:
> >
> > Christoph> None of the exported symbols is referenced by a module,
> > Christoph> even more the file doesn't compile shen
> > Christoph> CONFIG_IA64_SGI_SN_DEBUG is set.
> >
> > There are some device drivers coming that will depend on some of these
> > symbols so I'd prefer to keep this file in place, at least for
> > now. And yes, said drivers are GPL'ed.
>
> Or just move that stuff when we submit the drivers. I think Robin
> looked at this a bit...
I thought the sn_ksyms was already gone in 2.6. I would say, go ahead
and remove it. We will include our EXPORT_SYMBOLs for the symbols
we need at that time.
For 2.4, I guess I would say it isn't worth messing with.
Robin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] kill sn_ksyms.c
2003-09-25 19:54 [PATCH] kill sn_ksyms.c Christoph Hellwig
` (3 preceding siblings ...)
2003-10-06 18:18 ` Robin Holt
@ 2003-10-07 8:09 ` Christoph Hellwig
4 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2003-10-07 8:09 UTC (permalink / raw)
To: linux-ia64
On Mon, Oct 06, 2003 at 01:18:21PM -0500, Robin Holt wrote:
> I thought the sn_ksyms was already gone in 2.6. I would say, go ahead
> and remove it. We will include our EXPORT_SYMBOLs for the symbols
> we need at that time.
>
> For 2.4, I guess I would say it isn't worth messing with.
All patches I send are for 2.6 only. If you want them for 2.4 aswell
feel free to backport it, but I don't even look at 2.4 anymore these
days.
^ permalink raw reply [flat|nested] 6+ messages in thread