[2.6 PATCH] Missing exported symbol

[2.6 PATCH] Missing exported symbol

[Andreas Schwab]

This fixes some missing symbol exports.

Andreas.

--- linux-2.6.0-test7.orig/arch/ia64/kernel/ia64_ksyms.c	2003-10-08 21:24:04.000000000 +0200
+++ linux-2.6.0-test7/arch/ia64/kernel/ia64_ksyms.c	2003-10-17 13:10:43.000000000 +0200
@@ -41,6 +41,7 @@
 EXPORT_SYMBOL(csum_tcpudp_magic);
 EXPORT_SYMBOL(ip_compute_csum);
 EXPORT_SYMBOL(ip_fast_csum);
+EXPORT_SYMBOL(csum_partial);
 
 #include <asm/io.h>
 EXPORT_SYMBOL(__ia64_memcpy_fromio);
@@ -61,6 +62,8 @@
 #include <asm/pgtable.h>
 EXPORT_SYMBOL(vmalloc_end);
 EXPORT_SYMBOL(ia64_pfn_valid);
+EXPORT_SYMBOL(max_low_pfn);
+EXPORT_SYMBOL(vmem_map);
 #endif
 
 #include <asm/processor.h>
@@ -213,3 +216,7 @@
 
 #include <linux/pm.h>
 EXPORT_SYMBOL(pm_idle);
+
+#include <linux/reboot.h>
+EXPORT_SYMBOL(machine_power_off);
+EXPORT_SYMBOL(machine_restart);

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [2.6 PATCH] Missing exported symbol

[Christoph Hellwig]

On Fri, Oct 17, 2003 at 01:12:07PM +0200, Andreas Schwab wrote:
> +EXPORT_SYMBOL(csum_partial);

ok.

> @@ -61,6 +62,8 @@
>  #include <asm/pgtable.h>
>  EXPORT_SYMBOL(vmalloc_end);
>  EXPORT_SYMBOL(ia64_pfn_valid);
> +EXPORT_SYMBOL(max_low_pfn);
> +EXPORT_SYMBOL(vmem_map);

what needs these?

> +#include <linux/reboot.h>
> +EXPORT_SYMBOL(machine_power_off);
> +EXPORT_SYMBOL(machine_restart);

dito.  If these are needed the export should probably go into
architecture-independent code.

Re: [2.6 PATCH] Missing exported symbol

[Andreas Schwab]

Christoph Hellwig <hch@infradead.org> writes:

> On Fri, Oct 17, 2003 at 01:12:07PM +0200, Andreas Schwab wrote:
>> +EXPORT_SYMBOL(csum_partial);
>
> ok.
>
>> @@ -61,6 +62,8 @@
>>  #include <asm/pgtable.h>
>>  EXPORT_SYMBOL(vmalloc_end);
>>  EXPORT_SYMBOL(ia64_pfn_valid);
>> +EXPORT_SYMBOL(max_low_pfn);
>> +EXPORT_SYMBOL(vmem_map);
>
> what needs these?

Anything that uses virt_addr_valid (net/scpt).

>> +#include <linux/reboot.h>
>> +EXPORT_SYMBOL(machine_power_off);
>> +EXPORT_SYMBOL(machine_restart);
>
> dito.

drivers/char/watchdog/pcwd

>  If these are needed the export should probably go into
> architecture-independent code.

Those are architecture dependent functions, implemented under arch.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [2.6 PATCH] Missing exported symbol

[Jesse Barnes]

On Fri, Oct 17, 2003 at 02:17:09PM +0200, Andreas Schwab wrote:
> Christoph Hellwig <hch@infradead.org> writes:
> 
> > On Fri, Oct 17, 2003 at 01:12:07PM +0200, Andreas Schwab wrote:
> >> +EXPORT_SYMBOL(csum_partial);
> >
> > ok.
> >
> >> @@ -61,6 +62,8 @@
> >>  #include <asm/pgtable.h>
> >>  EXPORT_SYMBOL(vmalloc_end);
> >>  EXPORT_SYMBOL(ia64_pfn_valid);
> >> +EXPORT_SYMBOL(max_low_pfn);
> >> +EXPORT_SYMBOL(vmem_map);
> >
> > what needs these?
> 
> Anything that uses virt_addr_valid (net/scpt).

Yep, my fault.  Sorry I forgot to export them.  I've only tested a few
modules so far so I didn't catch the missing symbols.

That said, shouldn't these symols be exported in the files that contain
them?

Jesse

Re: [2.6 PATCH] Missing exported symbol

[Andreas Schwab]

jbarnes@sgi.com (Jesse Barnes) writes:

> That said, shouldn't these symols be exported in the files that contain
> them?

Yes, that's true.  We should eventually remove all exports from
ia64_ksyms.c except those that are implemented in assembler.  But I think
we should postpone that after test8 since Linus only wants bug fixes at
this time.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [2.6 PATCH] Missing exported symbol

[David Mosberger]

>>>>> On Fri, 17 Oct 2003 13:12:07 +0200, Andreas Schwab <schwab@suse.de> said:

  Andreas> +EXPORT_SYMBOL(machine_power_off);
  Andreas> +EXPORT_SYMBOL(machine_restart);

These are supposed to be exported where they get defined (actually,
true for everything in ia64_ksyms.c).  I had a fix for this, but due
to operator-error it got lost.  I'll re-fix it.

	--david

Re: [2.6 PATCH] Missing exported symbol

[Grant Grundler]

On Fri, Oct 17, 2003 at 01:12:07PM +0200, Andreas Schwab wrote:
> +EXPORT_SYMBOL(csum_partial);

yeah - the netfilter code needs this.
2.6.0-test7 plus csum_partial is running on my external box now.
I've uploaded tarball of vmlinuz+config+modules to
	ftp://gsyprf10.external.hp.com/kernels/ia64/2.6.0-test7.tgz

setserial crashes the box though. bjorn is looking into it.
(2.6.0-test5 returns EBUSY to setserial)
I've "apt-get remove setserial" since I don't need setserial.

hth,
grant