Re: [PATCH] Re: Gate DSO not building properly?

["H. J. Lu" <hjl@lucon.org>]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

On Wed, Oct 22, 2003 at 01:45:47PM +1000, Ian Wienand wrote:
> On Tue, Oct 21, 2003 at 04:10:51PM +1000, Ian Wienand wrote:
> > arch/ia64/kernel/gate-data.S:1: Warning: setting incorrect section
> > attributes for .data.gate
> 
> I figured out why (sorry if it's obvious); gas matches anything with
> prefix '.data.' as a data special section and flags it as 'SHF_ALLOC +
> SHF_WRITE' as per ELF [*].  Issuing 
> 
> .section .data.gate, "ax"
> 
> thus conflicts as it's assumed to be an extension of a .data section.
> 

Here is a patch for gas. Gas should set the right section attributes
no matter what.


H.J.

[-- Attachment #2: gas-attr-1.patch --]
[-- Type: text/plain, Size: 948 bytes --]

2003-10-21  H.J. Lu  <hongjiu.lu@intel.com>

	* config/obj-elf.c (obj_elf_change_section): Use specified
	section attributes.

--- gas/config/obj-elf.c.attr	2003-09-23 08:16:44.000000000 -0700
+++ gas/config/obj-elf.c	2003-10-21 22:31:51.000000000 -0700
@@ -615,6 +615,7 @@ obj_elf_change_section (name, type, attr
   segT sec;
   flagword flags;
   const struct bfd_elf_special_section *ssect;
+  bfd_boolean override = FALSE;
 
 #ifdef md_flush_pending_output
   md_flush_pending_output ();
@@ -685,10 +686,13 @@ obj_elf_change_section (name, type, attr
 		   && (attr &~ ssect->attr &~ SHF_MERGE &~ SHF_STRINGS) == 0)
 	    ;
 	  else
-	    as_warn (_("setting incorrect section attributes for %s"),
-		     name);
+	    {
+	      as_warn (_("setting incorrect section attributes for %s"),
+		       name);
+	      override = TRUE;
+	    }
 	}
-      if (old_sec == NULL)
+      if (!override && old_sec == NULL)
 	attr |= ssect->attr;
     }