From: David Mosberger <davidm@napali.hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] Re: Gate DSO not building properly?
Date: Wed, 22 Oct 2003 18:08:20 +0000 [thread overview]
Message-ID: <marc-linux-ia64-106684611528567@msgid-missing> (raw)
In-Reply-To: <marc-linux-ia64-106679437709356@msgid-missing>
>>>>> On Wed, 22 Oct 2003 13:45:47 +1000, Ian Wienand <ianw@gelato.unsw.edu.au> said:
Ian> On Tue, Oct 21, 2003 at 04:10:51PM +1000, Ian Wienand wrote:
>> arch/ia64/kernel/gate-data.S:1: Warning: setting incorrect
>> section attributes for .data.gate
Ian> I figured out why (sorry if it's obvious); gas matches anything
Ian> with prefix '.data.' as a data special section and flags it as
Ian> 'SHF_ALLOC + SHF_WRITE' as per ELF [*].
It wasn't obvious to me. I really disklike all this section-name
based matching in BFD/GAS, but it appears to ingrained to have an easy
fix.
Ian> Issuing
Ian> .section .data.gate, "ax"
Ian> thus conflicts as it's assumed to be an extension of a .data
Ian> section.
Ian> Should this even be in data at all, considering it's code?
Ian> What about something along the lines of the attached patch
Ian> which puts it in it's own section?
Actually, as far as the kernel is concerned, it _is_ data. Only when
it's mapped at the gate address is it used as text. I'm not sure why
I put "ax" there---it was most likely a left-over from earlier
experimentation. So I think the fix is to change "ax" to "aw" (the
data isn't really writable, but to avoid losing more memory to
page-alignment, it's better to keep the gate page in the writeable
data section). Do you want to try this?
--david
next prev parent reply other threads:[~2003-10-22 18:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-22 3:45 [PATCH] Re: Gate DSO not building properly? Ian Wienand
2003-10-22 5:48 ` H. J. Lu
2003-10-22 18:08 ` David Mosberger [this message]
2003-10-23 1:52 ` Ian Wienand
2003-10-23 4:56 ` David Mosberger
2003-10-24 10:07 ` Nick Clifton
2003-10-24 12:06 ` Matthew Wilcox
2003-10-24 12:21 ` Andreas Schwab
2003-10-24 15:15 ` H. J. Lu
2003-10-24 18:27 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=marc-linux-ia64-106684611528567@msgid-missing \
--to=davidm@napali.hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox