Fix compiler warning in arch/ia64/kernel/irq_lsapic.c

Fix compiler warning in arch/ia64/kernel/irq_lsapic.c

[Jack Steiner]

Not sure if you are taking fixes like this right now, but...

This fixes a compoiler warning that occurs when NR_CPUS is > 64.



--- linux_base/arch/ia64/kernel/irq_lsapic.c	Wed Nov  5 08:39:39 2003
+++ linux/arch/ia64/kernel/irq_lsapic.c	Wed Nov  5 08:38:27 2003
@@ -34,5 +34,5 @@
 	.disable =	lsapic_noop,
 	.ack =		lsapic_noop,
 	.end =		lsapic_noop,
-	.set_affinity =	(void (*)(unsigned int, unsigned long)) lsapic_noop
+	.set_affinity =	(void (*)(unsigned int, cpumask_t)) lsapic_noop
 };



-- 
Thanks

Jack Steiner (steiner@sgi.com)          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.

Re: Fix compiler warning in arch/ia64/kernel/irq_lsapic.c

[Christoph Hellwig]

On Wed, Nov 05, 2003 at 08:44:26AM -0600, Jack Steiner wrote:
> Not sure if you are taking fixes like this right now, but...
> 
> This fixes a compoiler warning that occurs when NR_CPUS is > 64.

I think the right fix would be to just not set this value, IIRC
set_affinity is optional.

--
Christoph Hellwig <hch@lst.de>		-	Freelance Hacker
Contact me for driver hacking and kernel development consulting

Re: Fix compiler warning in arch/ia64/kernel/irq_lsapic.c

[Jack Steiner]

On Wed, Nov 05, 2003 at 04:14:33PM +0000, Christoph Hellwig wrote:
> On Wed, Nov 05, 2003 at 08:44:26AM -0600, Jack Steiner wrote:
> > Not sure if you are taking fixes like this right now, but...
> > 
> > This fixes a compoiler warning that occurs when NR_CPUS is > 64.
> 
> I think the right fix would be to just not set this value, IIRC
> set_affinity is optional.

Good point. The field looks like it is optional. Should I update 
the patch???


> 
> --
> Christoph Hellwig <hch@lst.de>		-	Freelance Hacker
> Contact me for driver hacking and kernel development consulting

-- 
Thanks

Jack Steiner (steiner@sgi.com)          651-683-5302
Principal Engineer                      SGI - Silicon Graphics, Inc.

Re: Fix compiler warning in arch/ia64/kernel/irq_lsapic.c

[David Mosberger]

>>>>> On Wed, 5 Nov 2003 20:36:32 -0600, Jack Steiner <steiner@sgi.com> said:

  Jack> On Wed, Nov 05, 2003 at 04:14:33PM +0000, Christoph Hellwig wrote:
  >> On Wed, Nov 05, 2003 at 08:44:26AM -0600, Jack Steiner wrote:
  >> > Not sure if you are taking fixes like this right now, but...
  >> > 
  >> > This fixes a compoiler warning that occurs when NR_CPUS is > 64.
  >> 
  >> I think the right fix would be to just not set this value, IIRC
  >> set_affinity is optional.

  Jack> Good point. The field looks like it is optional. Should I update 
  Jack> the patch???

Yes, and please resend it after 2.6.0 is out, as this hardly qualifies
as a critical bug-fix.

	--david