[PATCH] fix 256 node machines by increasing NODES_SHIFT value

[PATCH] fix 256 node machines by increasing NODES_SHIFT value

[Jesse Barnes]

We need 8 bits for the NODE_SHIFT otherwise 256 node systems fail in
weird ways.

Thanks,
Jesse

=== include/asm-ia64/numnodes.h 1.3 vs edited ==--- 1.3/include/asm-ia64/numnodes.h	Wed Oct 22 06:26:08 2003
+++ edited/include/asm-ia64/numnodes.h	Tue Nov  4 10:48:55 2003
@@ -5,8 +5,8 @@
 /* Max 8 Nodes */
 #define NODES_SHIFT	3
 #elif defined(CONFIG_IA64_SGI_SN2) || defined(CONFIG_IA64_GENERIC)
-/* Max 128 Nodes */
-#define NODES_SHIFT	7
+/* Max 256 Nodes */
+#define NODES_SHIFT	8
 #endif
 
 #endif /* _ASM_MAX_NUMNODES_H */

Re: [PATCH] fix 256 node machines by increasing NODES_SHIFT value

[David Mosberger]

>>>>> On Tue, 4 Nov 2003 10:56:19 -0800, jbarnes@sgi.com (Jesse Barnes) said:

  Jesse> We need 8 bits for the NODE_SHIFT otherwise 256 node systems
  Jesse> fail in weird ways.

I think I'm going to push back on this one since Linus wants to limit
patches to stuff that affects (relatively) large number of folks, and
I don't think there are more than a handful of >256 node systems out
there (in fact, I've heard only of one).  Otherwise, I'm OK with the
patch, so we should include it in 2.6.1.  Please retransmit after
2.6.1 is out.

Ditto for Jack's patch.

OK?

	--david

Re: [PATCH] fix 256 node machines by increasing NODES_SHIFT value

[Jesse Barnes]

On Mon, Nov 10, 2003 at 06:01:53PM -0800, David Mosberger wrote:
> >>>>> On Tue, 4 Nov 2003 10:56:19 -0800, jbarnes@sgi.com (Jesse Barnes) said:
> 
>   Jesse> We need 8 bits for the NODE_SHIFT otherwise 256 node systems
>   Jesse> fail in weird ways.
> 
> I think I'm going to push back on this one since Linus wants to limit
> patches to stuff that affects (relatively) large number of folks, and
> I don't think there are more than a handful of >256 node systems out
> there (in fact, I've heard only of one).  Otherwise, I'm OK with the
> patch, so we should include it in 2.6.1.  Please retransmit after
> 2.6.1 is out.
> 
> Ditto for Jack's patch.
> 
> OK?

Yep, no problem.  Just posting it for comments more than anything else.

Jesse