From: "Jan Beulich" <JBeulich@novell.com>
To: linux-ia64@vger.kernel.org
Subject: Re: PATCH: Fix 2.6 kernel ia64 directives
Date: Thu, 03 Feb 2005 08:12:37 +0000 [thread overview]
Message-ID: <s201dcdd.091@emea1-mh.id2.novell.com> (raw)
In-Reply-To: <20050202221918.GA7973@lucon.org>
That is correct. However, to comply with this *AND* emit an error when a
symbol mentioned with .proc wasn't defined before the .endp, more
substantial changes to the assembler would be necessary (it would have
to keep track of all the symbols mentioned in .proc, which it currently
doesn't). I can certainly do such a change, but I think ignoring the
name arguments of .endp is a bad idea. Jan
>>> davidm@napali.hpl.hp.com 02.02.05 23:50:45 >>>
[Hi Jan, I sent this to HJ, assuming that he changed the assembler,
but looking through the ChangeLog, I now believe that you added the
.endp checking. I see you also added some unwind-directive sanity
checking and other useful improvements, which should be very
helpful.]
>>>>> On Wed, 2 Feb 2005 14:19:18 -0800, "H. J. Lu" <hjl@lucon.org>
said:
HJ> The new ia64 assembler caught a few directive bugs.
HJ> -END(idirty_bit)
HJ> +END(dirty_bit)
While I'm in favor of fixing such typos, the Itanium Assembly Language
Reference Manual states:
"The assembler ignores the name operands of the
directive."
(page 35 of document 248801-004).
In my opinion, a warning might be in place, but a hard error for
something that the spec explicitly allows seems like a bad idea to me.
--david
next prev parent reply other threads:[~2005-02-03 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-02 22:19 PATCH: Fix 2.6 kernel ia64 directives H. J. Lu
2005-02-02 22:50 ` David Mosberger
2005-02-03 8:12 ` Jan Beulich [this message]
2005-02-07 20:11 ` James E Wilson
2005-02-07 22:18 ` James E Wilson
2005-02-09 19:35 ` David Mosberger
2005-02-09 20:05 ` H. J. Lu
2005-02-09 20:10 ` James E Wilson
2005-02-09 21:11 ` David Mosberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s201dcdd.091@emea1-mh.id2.novell.com \
--to=jbeulich@novell.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox