__IA64_UNCACHED_OFFSET undefined...

__IA64_UNCACHED_OFFSET undefined...

[Peter Chubb]

Hi,
	Changeset
jes@wildopensource.com[torvalds]|ChangeSet|20050314001633|21074 
introduced new functions into include/asm-ia64/uaccess.h, and broke
IA64 compilation.  I think it needs the attached additional change:

Compile log shows:
include2/asm/uaccess.h: In function `xlate_dev_mem_ptr':
include2/asm/uaccess.h:382: error: `__IA64_UNCACHED_OFFSET' undeclared (first use in this function)
include2/asm/uaccess.h:382: error: (Each undeclared identifier is reported only once
include2/asm/uaccess.h:382: error: for each function it appears in.)
include2/asm/uaccess.h: In function `xlate_dev_kmem_ptr':
include2/asm/uaccess.h:400: error: `__IA64_UNCACHED_OFFSET' undeclared (first use in this function)


Index: linux-2.5-import/include/asm-ia64/uaccess.h
=================================--- linux-2.5-import.orig/include/asm-ia64/uaccess.h	2005-03-15 12:28:43.000428390 +1100
+++ linux-2.5-import/include/asm-ia64/uaccess.h	2005-03-16 12:32:32.899217137 +1100
@@ -40,6 +40,7 @@
 
 #include <asm/intrinsics.h>
 #include <asm/pgtable.h>
+#include <asm/io.h>
 
 /*
  * For historical reasons, the following macros are grossly misnamed:

Re: __IA64_UNCACHED_OFFSET undefined...

[Jes Sorensen]

>>>>> "Peter" = Peter Chubb <peterc@gelato.unsw.edu.au> writes:

Peter> Hi, Changeset
Peter> jes@wildopensource.com[torvalds]|ChangeSet|20050314001633|21074
Peter> introduced new functions into include/asm-ia64/uaccess.h, and
Peter> broke IA64 compilation.  I think it needs the attached
Peter> additional change:

I'm fine with the change, just curious what your config is - it
compiled fine for me when I pushed it.

Cheers,
Jes

Re: __IA64_UNCACHED_OFFSET undefined...

[Peter Chubb]

>>>>> "Jes" = Jes Sorensen <jes@wildopensource.com> writes:

>>>>> "Peter" = Peter Chubb <peterc@gelato.unsw.edu.au> writes:
Peter> Hi, Changeset
Peter> jes@wildopensource.com[torvalds]|ChangeSet|20050314001633|21074
Peter> introduced new functions into include/asm-ia64/uaccess.h, and
Peter> broke IA64 compilation.  I think it needs the attached
Peter> additional change:

Jes> I'm fine with the change, just curious what your config is - it
Jes> compiled fine for me when I pushed it.


Uniprocessor ZX1:  see http://www.gelato.unsw.edu.au/kerncomp
and
http://gelato.unsw.edu.au/kerncomp/results//2005-03-15-16-00/config-2.6.5-i2-uni-log.html


-- 
Dr Peter Chubb  http://www.gelato.unsw.edu.au  peterc AT gelato.unsw.edu.au
The technical we do immediately,  the political takes *forever*

Re: __IA64_UNCACHED_OFFSET undefined...

[Jes Sorensen]

>>>>> "Peter" = Peter Chubb <peterc@gelato.unsw.edu.au> writes:

>>>>> "Jes" = Jes Sorensen <jes@wildopensource.com> writes:
>>>>> "Peter" = Peter Chubb <peterc@gelato.unsw.edu.au> writes:
Peter> Hi, Changeset
Peter> jes@wildopensource.com[torvalds]|ChangeSet|20050314001633|21074
Peter> introduced new functions into include/asm-ia64/uaccess.h, and
Peter> broke IA64 compilation.  I think it needs the attached
Peter> additional change:

Jes> I'm fine with the change, just curious what your config is - it
Jes> compiled fine for me when I pushed it.

Peter> Uniprocessor ZX1: see http://www.gelato.unsw.edu.au/kerncomp
Peter> and

I assume it was just an old config you used? Anyway if you add a
signed-off-by I'll be happy to forward it to Linus.

Cheers,
Jes