From: Jes Sorensen <jes@sgi.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
tony.luck@intel.com, linux-ia64@vger.kernel.org,
torvalds@osdl.org
Subject: Re: [RFC][patch 09/44] IA64: Use the new IRQF_ constansts
Date: Mon, 03 Jul 2006 11:36:42 +0000 [thread overview]
Message-ID: <yq0r712hqd1.fsf@jaguar.mkp.net> (raw)
In-Reply-To: <20060701145224.258259000@cruncher.tec.linutronix.de>
>>>>> "Thomas" = Thomas Gleixner <tglx@linutronix.de> writes:
Thomas> Use the new IRQF_ constants and remove the SA_INTERRUPT define
Hi Thomas,
You forgot to remove the duplicate define of IRQF_PERCPU from
include/asm-ia64/irq.h when you introduced the one in
include/linux/interrupt.h.
On ia64, without this patch, building Linus' git tree spits out
compile warnings left right and center (harmless ones though).
I checked the ia64 code and I don't see any place that actually relied
on the old define or hardcoded it in asm, but I could be wrong of
course.
It compiles, it boots, Enterprise Ready<tm>!
Linus and/or Tony, please apply.
Cheers,
Jes
Remove duplicate define of IRQF_PERCPU which is now defined in
include/linux/interrupt.h
Signed-off-by: Jes Sorensen <jes@sgi.com>
---
include/asm-ia64/irq.h | 2 --
1 file changed, 2 deletions(-)
Index: linux-2.6/include/asm-ia64/irq.h
=================================--- linux-2.6.orig/include/asm-ia64/irq.h
+++ linux-2.6/include/asm-ia64/irq.h
@@ -14,8 +14,6 @@
#define NR_IRQS 256
#define NR_IRQ_VECTORS NR_IRQS
-#define IRQF_PERCPU 0x02000000
-
static __inline__ int
irq_canonicalize (int irq)
{
next parent reply other threads:[~2006-07-03 11:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060701145211.856500000@cruncher.tec.linutronix.de>
[not found] ` <20060701145224.258259000@cruncher.tec.linutronix.de>
2006-07-03 11:36 ` Jes Sorensen [this message]
2006-07-03 11:56 ` [RFC][patch 09/44] IA64: Use the new IRQF_ constansts Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq0r712hqd1.fsf@jaguar.mkp.net \
--to=jes@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox