Re: [RFC][patch 09/44] IA64: Use the new IRQF_ constansts

Re: [RFC][patch 09/44] IA64: Use the new IRQF_ constansts

[Jes Sorensen]

>>>>> "Thomas" = Thomas Gleixner <tglx@linutronix.de> writes:

Thomas> Use the new IRQF_ constants and remove the SA_INTERRUPT define

Hi Thomas,

You forgot to remove the duplicate define of IRQF_PERCPU from
include/asm-ia64/irq.h when you introduced the one in
include/linux/interrupt.h.

On ia64, without this patch, building Linus' git tree spits out
compile warnings left right and center (harmless ones though).

I checked the ia64 code and I don't see any place that actually relied
on the old define or hardcoded it in asm, but I could be wrong of
course.

It compiles, it boots, Enterprise Ready<tm>!

Linus and/or Tony, please apply.

Cheers,
Jes

Remove duplicate define of IRQF_PERCPU which is now defined in
include/linux/interrupt.h

Signed-off-by: Jes Sorensen <jes@sgi.com>

---
 include/asm-ia64/irq.h |    2 --
 1 file changed, 2 deletions(-)

Index: linux-2.6/include/asm-ia64/irq.h
=================================--- linux-2.6.orig/include/asm-ia64/irq.h
+++ linux-2.6/include/asm-ia64/irq.h
@@ -14,8 +14,6 @@
 #define NR_IRQS		256
 #define NR_IRQ_VECTORS	NR_IRQS
 
-#define IRQF_PERCPU	0x02000000
-
 static __inline__ int
 irq_canonicalize (int irq)
 {

Re: [RFC][patch 09/44] IA64: Use the new IRQF_ constansts

[Thomas Gleixner]

On Mon, 2006-07-03 at 07:36 -0400, Jes Sorensen wrote:
> >>>>> "Thomas" = Thomas Gleixner <tglx@linutronix.de> writes:
> 
> Thomas> Use the new IRQF_ constants and remove the SA_INTERRUPT define
> 
> Hi Thomas,
> 
> You forgot to remove the duplicate define of IRQF_PERCPU from
> include/asm-ia64/irq.h when you introduced the one in
> include/linux/interrupt.h.
> 
> On ia64, without this patch, building Linus' git tree spits out
> compile warnings left right and center (harmless ones though).
> 
> I checked the ia64 code and I don't see any place that actually relied
> on the old define or hardcoded it in asm, but I could be wrong of
> course.
> 
> It compiles, it boots, Enterprise Ready<tm>!

Andrew sent a fix to Linus already.
	
	tglx