* Re: [RFC][patch 09/44] IA64: Use the new IRQF_ constansts [not found] ` <20060701145224.258259000@cruncher.tec.linutronix.de> @ 2006-07-03 11:36 ` Jes Sorensen 2006-07-03 11:56 ` Thomas Gleixner 0 siblings, 1 reply; 2+ messages in thread From: Jes Sorensen @ 2006-07-03 11:36 UTC (permalink / raw) To: Thomas Gleixner; +Cc: LKML, Andrew Morton, tony.luck, linux-ia64, torvalds >>>>> "Thomas" = Thomas Gleixner <tglx@linutronix.de> writes: Thomas> Use the new IRQF_ constants and remove the SA_INTERRUPT define Hi Thomas, You forgot to remove the duplicate define of IRQF_PERCPU from include/asm-ia64/irq.h when you introduced the one in include/linux/interrupt.h. On ia64, without this patch, building Linus' git tree spits out compile warnings left right and center (harmless ones though). I checked the ia64 code and I don't see any place that actually relied on the old define or hardcoded it in asm, but I could be wrong of course. It compiles, it boots, Enterprise Ready<tm>! Linus and/or Tony, please apply. Cheers, Jes Remove duplicate define of IRQF_PERCPU which is now defined in include/linux/interrupt.h Signed-off-by: Jes Sorensen <jes@sgi.com> --- include/asm-ia64/irq.h | 2 -- 1 file changed, 2 deletions(-) Index: linux-2.6/include/asm-ia64/irq.h =================================--- linux-2.6.orig/include/asm-ia64/irq.h +++ linux-2.6/include/asm-ia64/irq.h @@ -14,8 +14,6 @@ #define NR_IRQS 256 #define NR_IRQ_VECTORS NR_IRQS -#define IRQF_PERCPU 0x02000000 - static __inline__ int irq_canonicalize (int irq) { ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC][patch 09/44] IA64: Use the new IRQF_ constansts 2006-07-03 11:36 ` [RFC][patch 09/44] IA64: Use the new IRQF_ constansts Jes Sorensen @ 2006-07-03 11:56 ` Thomas Gleixner 0 siblings, 0 replies; 2+ messages in thread From: Thomas Gleixner @ 2006-07-03 11:56 UTC (permalink / raw) To: Jes Sorensen; +Cc: LKML, Andrew Morton, tony.luck, linux-ia64, torvalds On Mon, 2006-07-03 at 07:36 -0400, Jes Sorensen wrote: > >>>>> "Thomas" = Thomas Gleixner <tglx@linutronix.de> writes: > > Thomas> Use the new IRQF_ constants and remove the SA_INTERRUPT define > > Hi Thomas, > > You forgot to remove the duplicate define of IRQF_PERCPU from > include/asm-ia64/irq.h when you introduced the one in > include/linux/interrupt.h. > > On ia64, without this patch, building Linus' git tree spits out > compile warnings left right and center (harmless ones though). > > I checked the ia64 code and I don't see any place that actually relied > on the old define or hardcoded it in asm, but I could be wrong of > course. > > It compiles, it boots, Enterprise Ready<tm>! Andrew sent a fix to Linus already. tglx ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-03 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060701145211.856500000@cruncher.tec.linutronix.de>
[not found] ` <20060701145224.258259000@cruncher.tec.linutronix.de>
2006-07-03 11:36 ` [RFC][patch 09/44] IA64: Use the new IRQF_ constansts Jes Sorensen
2006-07-03 11:56 ` Thomas Gleixner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox