Re: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

Re: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

[jameshsu]

RESEND as TEXT FORMAT
----- Original Message -----
From: jameshsu
To: Jeff Garzik
Cc: Andrew Morton ; IDE/ATA development list ; tytso@us.ibm.com ; Matti
Aarnio ; James Bottomley ; Jason Wu ; laurence@mail.acard.com ; Daniel Weng
Sent: Thursday, November 08, 2007 7:28 PM
Subject: Re: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver


Hi Jeff,

Not really understand your patch listed below.
We do not provide ahci.c file to you, so we don't know where the patch came
from(diff from where)??
Who create this and how can we get ahci.c file?? Can you tell us??
BTW, please ONLY use PCI device ID "D" for this hardware.
ACARD needs to reserve the rest device IDs for other purpose.(DO NOT USE "E"
& "F")
{ PCI_VDEVICE(ARTOP, 0x000D), board_ahci }

Thanks!  From Acard---James Hsu
----- Original Message -----
From: Jeff Garzik
To: jameshsu
Cc: Andrew Morton ; IDE/ATA development list ; tytso@us.ibm.com ; Matti
Aarnio ; James Bottomley ; 'David Miller' ; Daniel Weng ; Jason Wu ;
laurence@mail.acard.com
Sent: Thursday, November 08, 2007 6:30 AM
Subject: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver


On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote:
> By the way, once you complete the SATA sample driver , please inform us ,
so
> we could modify, test and submit in the near future.
> If any chip info still missing or need us to involve, please let me know.

Any chance the patch below works?

Jeff


 drivers/ata/ahci.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ed9b407..7a42b4e 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -553,6 +553,11 @@ static const struct pci_device_id ahci_pci_tbl[] = {
  /* Marvell */
  { PCI_VDEVICE(MARVELL, 0x6145), board_ahci_mv }, /* 6145 */

+ /* Acard */
+ { PCI_VDEVICE(ARTOP, 0x000D), board_ahci },
+ { PCI_VDEVICE(ARTOP, 0x000E), board_ahci },
+ { PCI_VDEVICE(ARTOP, 0x000F), board_ahci },
+
  /* Generic, PCI class code for AHCI */
  { PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
    PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },

Re: Should be Acard ATP8620 2SATA / 1 IDE driver

[Jeff Garzik]

jameshsu wrote:
> Should be in TEXT/PLAIN mode. --- resend
> 
> ************************
> Hello,
> 
> This driver has nothing changed since last time submit.
> However recently we download 2.6.23.1 kernel and found Acard ATP8620 SATA
> driver is still not there.
> Resend this message to submit the same driver again.
> Please help Acard to build in this SATA driver with latest Linux kernel.
> If any reason not able to add in, please let us know.

We would be glad to help!

This driver is an ATA driver, which duplicates the existing SCSI<->ATA 
translation code we already have.  It also fails to work around the 
problems ("quirks") found in a large number of ATA devices.

As such, it would be preferred that this ATA hardware use the existing 
ATA driver API.

You can see example drivers for advanced controllers such a 
drivers/ata/ahci.c and drivers/ata/sata_sil24.c, which are both 
FIS-based controllers with full NCQ support, hotplug support, port 
multiplier support, and many others.

It is important in Linux that we do not duplicate effort by merging 
drivers that duplicate the existing SCSI<->ATA translation layer, or 
fail to use our existing ATA API.

Overall, we wish to avoid adding another ATA driver inside the SCSI 
layer, without using the existing ATA<->SCSI code.

Is your hardware documentation public?  I can help provide a sample 
driver for your hardware, or help guide your engineers in this effort.

Regards,

	Jeff, the Linux ATA maintainer

Re: Should be Acard ATP8620 2SATA / 1 IDE driver

[jameshsu]

Hi Jeff,

".....Is your hardware documentation public?  I can help provide a sample
driver for your hardware, or help guide your engineers in this
effort........"
 =>>>>>  Product spec is under preparation, will be provided soon.
Right after doc public, please help us to provide a sample driver in your
eralier conveniance??
This way to ensure SATA driver of this hardware will be compliance with
Linux kernel requirement.
Thanks!

James Hsu
----- Original Message -----
From: Jeff Garzik
To: jameshsu
Cc: linux-scsi@vger.kernel.org ; 'David Miller' ; James Bottomley ; Matti
Aarnio ; tytso@us.ibm.com ; IDE/ATA development list ; Andrew Morton
Sent: Tuesday, October 30, 2007 6:24 PM
Subject: Re: Should be Acard ATP8620 2SATA / 1 IDE driver


jameshsu wrote:
> Should be in TEXT/PLAIN mode. --- resend
>
> ************************
> Hello,
>
> This driver has nothing changed since last time submit.
> However recently we download 2.6.23.1 kernel and found Acard ATP8620 SATA
> driver is still not there.
> Resend this message to submit the same driver again.
> Please help Acard to build in this SATA driver with latest Linux kernel.
> If any reason not able to add in, please let us know.

We would be glad to help!

This driver is an ATA driver, which duplicates the existing SCSI<->ATA
translation code we already have.  It also fails to work around the
problems ("quirks") found in a large number of ATA devices.

As such, it would be preferred that this ATA hardware use the existing
ATA driver API.

You can see example drivers for advanced controllers such a
drivers/ata/ahci.c and drivers/ata/sata_sil24.c, which are both
FIS-based controllers with full NCQ support, hotplug support, port
multiplier support, and many others.

It is important in Linux that we do not duplicate effort by merging
drivers that duplicate the existing SCSI<->ATA translation layer, or
fail to use our existing ATA API.

Overall, we wish to avoid adding another ATA driver inside the SCSI
layer, without using the existing ATA<->SCSI code.

Is your hardware documentation public?  I can help provide a sample
driver for your hardware, or help guide your engineers in this effort.

Regards,

Jeff, the Linux ATA maintainer

[PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

[Jeff Garzik]

On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote:
> By the way, once you complete the SATA sample driver , please inform us , so
> we could modify, test and submit in the near future.
> If any chip info still missing or need us to involve, please let me know.

Any chance the patch below works?

	Jeff


 drivers/ata/ahci.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index ed9b407..7a42b4e 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -553,6 +553,11 @@ static const struct pci_device_id ahci_pci_tbl[] = {
 	/* Marvell */
 	{ PCI_VDEVICE(MARVELL, 0x6145), board_ahci_mv },	/* 6145 */
 
+	/* Acard */
+	{ PCI_VDEVICE(ARTOP, 0x000D), board_ahci },
+	{ PCI_VDEVICE(ARTOP, 0x000E), board_ahci },
+	{ PCI_VDEVICE(ARTOP, 0x000F), board_ahci },
+
 	/* Generic, PCI class code for AHCI */
 	{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
 	  PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },

Re: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

[Jeff Garzik]

On Thu, Nov 08, 2007 at 07:28:38PM +0800, jameshsu wrote:
> Not really understand your patch listed below. 
> We do not provide ahci.c file to you, so we don't know where the patch came from(diff from where)?? 
> Who create this and how can we get ahci.c file?? Can you tell us??

The file is found in the latest kernel source code.  Go to

	http://www.kernel.org/

and download the latest "full" kernel version, 2.6.23:

	http://www.kernel.org/pub/linux/kernel/v2.6/linux-2.6.23.tar.bz2

and then to get the latest kernel, apply this patch:

	http://www.kernel.org/pub/linux/kernel/v2.6/testing/patch-2.6.24-rc2.bz2

Let me know if you need help unpacking and patching the kernel!

	Jeff