Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Arnd Bergmann <arnd@arndb.de>, Anders Roxell <anders.roxell@linaro.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	open list <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	regressions@lists.linux.dev,
	"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
	<linux-ide@vger.kernel.org>,
	lkft-triage@lists.linaro.org,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Niklas Cassel <niklas.cassel@wdc.com>
Subject: Re: TI: X15 the connected SSD is not detected on Linux next 20221006 tag
Date: Fri, 14 Oct 2022 18:47:23 +0900	[thread overview]
Message-ID: <0ea781f8-6911-2850-16a2-cee230dd32b0@opensource.wdc.com> (raw)
In-Reply-To: <d087c831-1519-4b83-8cc1-5317659709be@app.fastmail.com>

On 10/14/22 18:37, Arnd Bergmann wrote:
> On Fri, Oct 14, 2022, at 11:22 AM, Anders Roxell wrote:
>> On Fri, 14 Oct 2022 at 09:53, Damien Le Moal
> 
>> Tested this patch on todays linux-next tag: next-20221014 without enabling
>> CONFIG_AHCI_DWC and it worked as expected when booting [1].
>> On the other hand I also tried a build/boot with CONFIG_AHCI_DWC enabled
>> and it worked as expected to boot [2].

That is great news ! So the new driver is OK, good !

> 
> Ok, great. Can you a patch to soc@kernel.org to enable the driver in the
> relevant defconfigs?
> 
>> However, during building a warning [3] popped up:
>>
>> make --silent --keep-going --jobs=8
>> O=/home/tuxbuild/.cache/tuxmake/builds/2/build ARCH=arm
>> CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
>> arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
>> /builds/linux/drivers/ata/ahci_dwc.c:462:34: warning: 'ahci_dwc_plat'
>> defined but not used [-Wunused-variable]
>>   462 | static struct ahci_dwc_plat_data ahci_dwc_plat = {
> 
> Strange, I can't reproduce this, and the ahci_dwc_plat symbol
> looks like it is clearly used in ahci_dwc_of_match[], at least
> in next-20221014. Do you also see this on mainline?

This is with the trial fix diff I sent. My bad, it was not even compile
tested :). Does not happen otherwise.

>       Arnd

Thanks for helping with this !

-- 
Damien Le Moal
Western Digital Research


  reply	other threads:[~2022-10-14  9:47 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12  7:24 TI: X15 the connected SSD is not detected on Linux next 20221006 tag Naresh Kamboju
2022-10-13  7:11 ` Damien Le Moal
2022-10-13 12:39   ` Naresh Kamboju
2022-10-13 22:07     ` Anders Roxell
2022-10-14  0:22       ` Damien Le Moal
2022-10-14  7:31         ` Arnd Bergmann
2022-10-14  7:53           ` Damien Le Moal
2022-10-14  9:22             ` Anders Roxell
2022-10-14  9:37               ` Arnd Bergmann
2022-10-14  9:47                 ` Damien Le Moal [this message]
2022-10-14 14:06               ` Serge Semin
2022-10-17  7:43                 ` Anders Roxell
2022-10-17 15:52                   ` Serge Semin
2022-11-30  9:40                     ` Naresh Kamboju
2022-11-30 10:03                       ` Niklas Cassel
2022-12-01 11:48                         ` Anders Roxell
2022-12-05  1:11                           ` Serge Semin
2022-12-05 10:08                             ` Arnd Bergmann
2022-12-05 13:24                               ` Damien Le Moal
2022-12-06  8:46                                 ` Serge Semin
2022-12-06  9:12                                   ` Damien Le Moal
2022-12-06 21:04                                     ` Serge Semin
2022-12-01 13:02                       ` TI: X15 the connected SSD is not detected on Linux next 20221006 tag #forregzbot Thorsten Leemhuis
2022-12-07  5:40                         ` Thorsten Leemhuis
2022-10-14 13:38           ` TI: X15 the connected SSD is not detected on Linux next 20221006 tag Serge Semin
2022-10-14 13:36         ` Serge Semin
2022-10-14  0:17     ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ea781f8-6911-2850-16a2-cee230dd32b0@opensource.wdc.com \
    --to=damien.lemoal@opensource.wdc.com \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=niklas.cassel@wdc.com \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox