Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]

On Wed, 2010-09-29 at 18:50 +0200, thomas.debesse+debian@gmail.com
wrote:
[...]
> ICH6 sata controller could be managed by both ata_piix and ahci module but only
> ahci module handle hotplug.
> At boot time, when ata_piix is loaded before ahci module, it takes control of
> the ICH6 controller and the ahci module does'nt manage nothing. Because
> ata_piix also manage ICH6 sata controller, hard drives are managed, but because
> ata_piix module is used in place of ahci module, because ahci module is'nt
> used, hotplug (and other ahci functionnalities indeed) does'nt works.
[...]
> The solution is to load ahci module before ata_piix module, then we can have
> SATA drives managed by ahci module and IDE drives managed by ata_piix module.
[...]

You can force ahci to be loaded first:
1. Add the line 'ahci' to /etc/initramfs-tools/modules.
2. Run 'update-initramfs -u' to regenerate the initramfs.
3. Reboot.

But it seems like it would be better if ahci was automatically
preferred.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[Tejun Heo]

Hello,

On 09/30/2010 12:27 AM, Ben Hutchings wrote:
> On Wed, 2010-09-29 at 18:50 +0200, thomas.debesse+debian@gmail.com
> wrote:
> [...]
>> ICH6 sata controller could be managed by both ata_piix and ahci module but only
>> ahci module handle hotplug.
>> At boot time, when ata_piix is loaded before ahci module, it takes control of
>> the ICH6 controller and the ahci module does'nt manage nothing. Because
>> ata_piix also manage ICH6 sata controller, hard drives are managed, but because
>> ata_piix module is used in place of ahci module, because ahci module is'nt
>> used, hotplug (and other ahci functionnalities indeed) does'nt works.
> [...]
>> The solution is to load ahci module before ata_piix module, then we can have
>> SATA drives managed by ahci module and IDE drives managed by ata_piix module.
> [...]
> 
> You can force ahci to be loaded first:
> 1. Add the line 'ahci' to /etc/initramfs-tools/modules.
> 2. Run 'update-initramfs -u' to regenerate the initramfs.
> 3. Reboot.
> 
> But it seems like it would be better if ahci was automatically
> preferred.

With modules.order in place, modprobe will always prefer ahci over
ata_piix (the preference follows the link order).  Maybe debian initrd
doesn't handle modules.order properly?

Thanks.

-- 
tejun

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[maximilian attems]

hello,

On Mon, Oct 04, 2010 at 06:46:51PM +0200, Tejun Heo wrote:
> >> The solution is to load ahci module before ata_piix module, then we can have
> >> SATA drives managed by ahci module and IDE drives managed by ata_piix module.
> > [...]
> > 
> > You can force ahci to be loaded first:
> > 1. Add the line 'ahci' to /etc/initramfs-tools/modules.
> > 2. Run 'update-initramfs -u' to regenerate the initramfs.
> > 3. Reboot.
> > 
> > But it seems like it would be better if ahci was automatically
> > preferred.
> 
> With modules.order in place, modprobe will always prefer ahci over
> ata_piix (the preference follows the link order).  Maybe debian initrd
> doesn't handle modules.order properly?

we do shipp modules.order in initramfs.

hmm thomas what are your MODULES settings, please post output of
 egrep MODULES -r /etc/initramfs-tools/

if MODULES=dep appears it could be that the sys walking code has
a bug in adding the wrong module to the initramfs.
please change it to the safe and default MODULES=most and regenerate:
update-initramfs -u -k <kernelversion>

you can check any initramfs if it has the relevant modules with
lsinitramfs /boot/initrd.img-2.6.35-trunk-amd64 | grep ahci 


thanks

-- 
maks

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[Thomas DEBESSE]

2010/9/30 Ben Hutchings <ben@decadent.org.uk>:
> On Wed, 2010-09-29 at 18:50 +0200, thomas.debesse+debian@gmail.com
> wrote:
> You can force ahci to be loaded first:
> 1. Add the line 'ahci' to /etc/initramfs-tools/modules.
> 2. Run 'update-initramfs -u' to regenerate the initramfs.
> 3. Reboot.

I've tested it, it does'nt change anything.
Nowadays, I blacklist ata_piix

# echo 'blacklist ata_piix' >> /etc/modprobe.d/blacklist.conf
# update-initramfs -k all -u
# reboot

then I manually load ata_piix using modprobe after boot

> But it seems like it would be better if ahci was automatically
> preferred.

Yes, because I'm not the only one using ich6 chipset who want to
upgrade from lenny to squeeze indeed. :)

2010/10/4 maximilian attems <max@stro.at>:
> we do shipp modules.order in initramfs.

It looks like what I'm looking for... a way to force loading of ahci
module before loading of ata_piix module.

> hmm thomas what are your MODULES settings, please post output of
>  egrep MODULES -r /etc/initramfs-tools/
>
> if MODULES=dep appears it could be that the sys walking code has
> a bug in adding the wrong module to the initramfs.
> please change it to the safe and default MODULES=most and regenerate:
> update-initramfs -u -k <kernelversion>
>
> you can check any initramfs if it has the relevant modules with
> lsinitramfs /boot/initrd.img-2.6.35-trunk-amd64 | grep ahci

I'm going to check this !

It can be important to point out that previously quoted lenny lspci
showed me it knows the two modules could be used and experience showed
me it does the good choice.

# diff lspci-lenny lspci-squeeze
16,18c16,17
<       Status: D0 PME-Enable- DSel=0 DScale=0 PME-
<    Kernel driver in use: ahci
<    Kernel modules: ahci, ata_piix
---
>       Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
>    Kernel driver in use: ata_piix

Squeeze lspci does'nt have this "Kernel modules" line even though both
modules are loaded.

So, I'm going to check modules.order and /etc/initramfs-tools/ then I
will report here what I can see.

-- 
Thomas DEBESSE

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[maximilian attems]

On Tue, Oct 05, 2010 at 09:45:40AM +0200, Thomas DEBESSE wrote:
> 
> So, I'm going to check modules.order and /etc/initramfs-tools/ then I
> will report here what I can see.
> 

please also report which initramfs-tools version you are using,
since lenny there had been ton of fixes:
dpkg -l initramfs-tools

you should be running 0.98.4

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[Thomas DEBESSE]

2010/10/4 maximilian attems <max@stro.at>:
> we do shipp modules.order in initramfs.

> hmm thomas what are your MODULES settings, please post output of
>  egrep MODULES -r /etc/initramfs-tools/

> you can check any initramfs if it has the relevant modules with
> lsinitramfs /boot/initrd.img-2.6.35-trunk-amd64 | grep ahci

2010/10/5 maximilian attems <max@stro.at>:
> please also report which initramfs-tools version you are using,
> since lenny there had been ton of fixes:
> dpkg -l initramfs-tools
>
> you should be running 0.98.4

Somes checks, playing with system configuration,

On Lenny:

# egrep MODULES -r /etc/initramfs-tools/
/etc/initramfs-tools/initramfs.conf:# MODULES: [ most | netboot | dep | list ]
/etc/initramfs-tools/initramfs.conf:MODULES=most

# lspci -vv -s 00:1f.2 | grep Kernel
	Kernel driver in use: ahci
	Kernel modules: ahci, ata_piix

# dpkg -l initramfs-tools | grep ^ii
ii  initramfs-tools                   0.92o                      tools
for generating an initramfs

# find / -iname "modules.order"

On Squeeze :

# egrep MODULES -r /etc/initramfs-tools/
/etc/initramfs-tools/initramfs.conf:# MODULES: [ most | netboot | dep | list ]
/etc/initramfs-tools/initramfs.conf:MODULES=most

# lspci -vv -s 00:1f.2 | grep Kernel
	Kernel driver in use: ata_piix

# dpkg -l initramfs-tools | grep ^ii
ii  initramfs-tools                   0.98.4
tools for generating an initramfs

# find / -iname "modules.order"

Nothing seems to be interesting here.

Playing with initrd,

On Lenny :

# lsinitramfs initrd.img-2.6.26-2-686 | grep 'ahci\|ata_piix'
lib/modules/2.6.26-2-686/kernel/drivers/ata/ahci.ko
lib/modules/2.6.26-2-686/kernel/drivers/ata/ata_piix.ko

# gunzip < initrd.img-2.6.26-2-686 | cpio -i --make-directories
# find . -iname '*module*'
./conf/modules
./lib/modules

On Squeeze (unmodified):

# lsinitramfs initrd.img-2.6.32-5-686 | grep 'ahci\|ata_piix'
lib/modules/2.6.32-5-686/kernel/drivers/ata/ahci.ko
lib/modules/2.6.32-5-686/kernel/drivers/ata/ata_piix.ko

# gunzip < initrd.img-2.6.32-5-686 | cpio -i --make-directories
# find . -iname '*module*'
./conf/modules
./lib/modules
./lib/modules/2.6.32-5-686/modules.symbols
./lib/modules/2.6.32-5-686/modules.dep
./lib/modules/2.6.32-5-686/modules.alias.bin
./lib/modules/2.6.32-5-686/modules.symbols.bin
./lib/modules/2.6.32-5-686/modules.alias
./lib/modules/2.6.32-5-686/modules.devname
./lib/modules/2.6.32-5-686/modules.dep.bin
./lib/modules/2.6.32-5-686/modules.softdep

On Squeeze (modified, with blacklist ata_piix):

# lsinitramfs initrd.img-2.6.32-5-686 | grep 'ahci\|ata_piix'
lib/modules/2.6.32-5-686/kernel/drivers/ata/ahci.ko
lib/modules/2.6.32-5-686/kernel/drivers/ata/ata_piix.ko

# gunzip < initrd.img-2.6.32-5-686 | cpio -i --make-directories
# find . -iname '*module*'
./conf/modules
./lib/modules
./lib/modules/2.6.32-5-686/modules.symbols
./lib/modules/2.6.32-5-686/modules.dep
./lib/modules/2.6.32-5-686/modules.alias.bin
./lib/modules/2.6.32-5-686/modules.symbols.bin
./lib/modules/2.6.32-5-686/modules.alias
./lib/modules/2.6.32-5-686/modules.devname
./lib/modules/2.6.32-5-686/modules.dep.bin
./lib/modules/2.6.32-5-686/modules.softdep

Comparing file 'conf/module' which is common to Lenny and Squeeze

# diff lenny/conf/modules squeeze-unmodified/conf/modules
# diff squeeze-unmodified/conf/modules squeeze-blacklist/conf/modules

Comparing somes Squeeze modified and unmodified initrds contents :

# for i in modules.symbols \
           modules.dep \
           modules.alias.bin \
           modules.symbols.bin \
           modules.alias \
           modules.devname \
           modules.dep.bin \
           modules.softdep
do diff squeeze-unmodified/lib/modules/2.6.32-5-686/$i \
        squeeze-blacklist/lib/modules/2.6.32-5-686/$i
done

# diff squeeze-unmodified/etc/modprobe.d/blacklist.conf
squeeze-blacklist/etc/modprobe.d/blacklist.conf
24a25
> blacklist ata_piix

# diff squeeze-blacklist/etc/modprobe.d/aliases.conf
squeeze-unmodified/etc/modprobe.d/aliases.conf
# diff lenny/etc/modprobe.d/aliases
squeeze-unmodified/etc/modprobe.d/aliases.conf
4,5c4,5
< # Please file a bug against module-init-tools if a package needs a entry
< # in this file.
---
> # No new aliases should be added to this file, please file a bug against
> # the kernel for any aliases which are still not built-in.
14c14
< alias net-pf-7  bridge
---
> # 7 BRIDGE
30c30
< alias net-pf-25 wanrouter
---
> # 25 WANROUTER
57,59d56
< alias block-major-8-*  sd_mod
< alias block-major-9-*  md
< alias block-major-11-* sr_mod
78d74
< alias char-major-9-* st
141,146c137,142
< alias bt-proto-0 l2cap
< alias bt-proto-2 sco
< alias bt-proto-3 rfcomm
< alias bt-proto-4 bnep
< alias bt-proto-5 cmtp
< alias bt-proto-6 hidp
---
> #alias bt-proto-0 l2cap
> #alias bt-proto-2 sco
> #alias bt-proto-3 rfcomm
> #alias bt-proto-4 bnep
> #alias bt-proto-5 cmtp
> #alias bt-proto-6 hidp
165a162,167
> # work around other kernel issues ############################################
> # The EHCI driver should be loaded before the ones for low speed controllers
> # or some devices may be confused when they are disconnected and reconnected.
> softdep uhci-hcd pre: ehci-hcd
> softdep ohci-hcd pre: ehci-hcd
>

Nothing seems to be interesting here...

Playing with kernel sources

# ar p linux-source-2.6.26_2.6.26-25lenny1_all.deb data.tar.gz|tar zx
# ar p linux-source-2.6.32_2.6.32-23_all.deb data.tar.gz|tar zx
# (cd /usr/src ; tar -xjf linux-source-2.6.26.tar.bz2)
# (cd /usr/src ; tar -xjf linux-source-2.6.32.tar.bz2)
# find usr/src/linux-source-2.6.26 -iname '*modules.order*'
# find usr/src/linux-source-2.6.32 -iname '*modules.order*'

Nothing seems to be interesting here...

Where can I find modules.order ?
Or where write it and how ?

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[Ben Hutchings]

On Wed, Oct 06, 2010 at 07:04:48PM +0200, Thomas DEBESSE wrote:
[...]
> Nothing seems to be interesting here...
> 
> Where can I find modules.order ?
> Or where write it and how ?
 
modules.order is generated during the kernel build process and will be
copied into the initramfs by update-initramfs if present.

However, we currently delete modules.* when creating the image packages,
because we assume all those files are generated by depmod.  Oops.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[Thomas DEBESSE]

Ben Hutchings <ben@decadent.org.uk>:
> modules.order is generated during the kernel build process and will be
> copied into the initramfs by update-initramfs if present.
>
> However, we currently delete modules.* when creating the image packages,
> because we assume all those files are generated by depmod.  Oops.

dann frazier <dannf@debian.org>:
> We believe that the bug you reported is fixed in the latest version of
> linux-2.6, which is due to be installed in the Debian FTP archive:

> linux-headers-2.6.32-5-686_2.6.32-25_i386.deb
>  to main/l/linux-2.6/linux-headers-2.6.32-5-686_2.6.32-25_i386.deb

I've just installed a fresh Squeeze and I got the new kernel :

# apt-cache show linux-image-2.6.32-5-686 | grep ^Version
Version: 2.6.32-25

I have the 2.6.32-25, wich was announced to solve the problem,
and yes this new one put modules.order in initramfs

# gunzip < initrd.img-2.6.32-5-686 | cpio -i --make-directories
45807 blocs

# find . -iname "*module*"
./lib/modules
./lib/modules/2.6.32-5-686/modules.softdep
./lib/modules/2.6.32-5-686/modules.symbols
./lib/modules/2.6.32-5-686/modules.symbols.bin
./lib/modules/2.6.32-5-686/modules.order
./lib/modules/2.6.32-5-686/modules.alias
./lib/modules/2.6.32-5-686/modules.dep
./lib/modules/2.6.32-5-686/modules.dep.bin
./lib/modules/2.6.32-5-686/modules.devname
./lib/modules/2.6.32-5-686/modules.alias.bin
./conf/modules

and ahci module appear before ata_piix in modules.order

# grep 'ahci\|ata_piix' ./lib/modules/2.6.32-5-686/modules.order
kernel/drivers/ata/ahci.ko
kernel/drivers/ata/ata_piix.ko

but the wrong module is always loaded :

# lspci -vvv -s 00:1f.2 | grep 'SATA\|Kernel driver'
00:1f.2 SATA controller: Intel Corporation 82801FR/FRW (ICH6R/ICH6RW)
SATA Controller (rev 03) (prog-if 01 [AHCI 1.0])
	Kernel driver in use: ata_piix

modules.order does'nt change anything.

Prevously quoted modules.aliases shows me a workaround for another
(unrelated) problem :

From module.aliases :
> # work around other kernel issues ############################################
> # The EHCI driver should be loaded before the ones for low speed controllers
> # or some devices may be confused when they are disconnected and reconnected.
> softdep uhci-hcd pre: ehci-hcd
> softdep ohci-hcd pre: ehci-hcd

I wrote a similar workaround to force ahci loading before ata_piix module :

# cat >> /etc/modprobe.d/aliases.conf <<\EOF
softdep ata_piix pre: ahci
EOF

# update-initramfs -k all -u
update-initramfs: Generating /boot/initrd.img-2.6.32-5-686

# reboot

# lspci -vvv -s 00:1f.2 | grep 'SATA\|Kernel driver'
00:1f.2 SATA controller: Intel Corporation 82801FR/FRW (ICH6R/ICH6RW)
SATA Controller (rev 03) (prog-if 01 [AHCI 1.0])
	Kernel driver in use: ahci

This workaround works and is cleaner than blacklisting ata_piix before
modprobing it :-)
But this is a workaround (a clean hack, but a hack, not a fix) and
Lenny kernel (2.6.26) does'nt need this workaround.
With Lenny, the job of knowing that two modules could be used, knowing
that one is better than another and choosing the good one is done by
software.
With Squeeze, this job is done by man...

Perhaps the bug is not related to the linux-image package, but a
collateral damage of another package ?

This bug is not fixed.

Re: Bug#598518: linux-image-2.6-686: ata_piix module loaded before ahci module deactivate hotplug support (regression from lenny)

[Thomas DEBESSE]

2010/10/20 Thomas DEBESSE <thomas.debesse+debian@gmail.com>:
> I've just installed a fresh Squeeze and I got the new kernel :
> I have the 2.6.32-25, wich was announced to solve the problem,
> and yes this new one put modules.order in initramfs
> but the wrong module is always loaded :
> This bug is not fixed.

The previous test was done with a livecd installing 2.6.32-24 then
upgrading to 2.6.32-25.
I've done another test with another fresh install but using a livecd
with 2.6.32-25 kernel.
The good module is loaded without modifying aliases.conf.

This bug seems fixed, but there is some persistence when upgrading
from previously installed Squeeze distros.


Thanx.