From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Niklas Cassel <cassel@kernel.org>
Cc: Damien Le Moal <dlemoal@kernel.org>, <linux-ide@vger.kernel.org>,
<lvc-project@linuxtesting.org>
Subject: Re: [PATCH] ata: ata_generic: use IS_ENABLED() macro
Date: Fri, 13 Sep 2024 22:36:15 +0300 [thread overview]
Message-ID: <1b2ee8d0-2ff1-79f0-8af2-51eb84c8d192@omp.ru> (raw)
In-Reply-To: <ZuPiUWlcNmBt9tqH@ryzen.lan>
On 9/13/24 9:57 AM, Niklas Cassel wrote:
[...]
>>> Maybe rename the option to CONFIG_PATA_TOSHIBA_PICCCOLO ?
>>
>> Nah, that doesn't make much sense to me; if we rename it, we should match the driver's name, i.e. make it CONFIG_PATA_PICCOLO. I'm mainly concerned about the
>> Linux distros which would have to handle such rename somehow, IIUC...
I wonder whether they could be using s/th like make allmodconfig...
> I still remember:
> 4dd4d3deb502 ("ata: ahci: Rename CONFIG_SATA_LPM_MOBILE_POLICY configuration item")
> and
> 55b014159ee7 ("ata: ahci: Rename CONFIG_SATA_LPM_POLICY configuration item back")
>
> so I also prefer to avoid renaming Kconfigs as far as possible.
Yeah, it does not look very likely ATM that tc86c001 support will be
revived... Although, could be done pretty easily if I don't try to work
around the infamous limitation #5...
> Kind regards,
> Niklas
MBR, Sergey
next prev parent reply other threads:[~2024-09-13 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 20:51 [PATCH] ata: ata_generic: use IS_ENABLED() macro Sergey Shtylyov
2024-09-10 4:50 ` Damien Le Moal
2024-09-10 8:52 ` Sergey Shtylyov
2024-09-10 13:09 ` Damien Le Moal
2024-09-10 14:32 ` Sergey Shtylyov
2024-09-10 14:36 ` Sergey Shtylyov
2024-09-10 22:22 ` Damien Le Moal
2024-09-11 17:14 ` Sergey Shtylyov
2024-09-13 6:57 ` Niklas Cassel
2024-09-13 19:36 ` Sergey Shtylyov [this message]
2024-09-14 17:53 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b2ee8d0-2ff1-79f0-8af2-51eb84c8d192@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox