Linux ATA/IDE development
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: Damien Le Moal <dlemoal@kernel.org>,
	linux-ide@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH] ata: ata_generic: use IS_ENABLED() macro
Date: Fri, 13 Sep 2024 08:57:21 +0200	[thread overview]
Message-ID: <ZuPiUWlcNmBt9tqH@ryzen.lan> (raw)
In-Reply-To: <5bed15cf-b6c2-62e9-c23d-7a3c94f2dcc2@omp.ru>

On Wed, Sep 11, 2024 at 08:14:32PM +0300, Sergey Shtylyov wrote:
> On 9/11/24 1:22 AM, Damien Le Moal wrote:
> > 
> > Maybe rename the option to CONFIG_PATA_TOSHIBA_PICCCOLO ?
> 
>    Nah, that doesn't make much sense to me; if we rename it, we should match the driver's name, i.e. make it CONFIG_PATA_PICCOLO.  I'm mainly concerned about the
> Linux distros which would have to handle such rename somehow, IIUC...

I still remember:
4dd4d3deb502 ("ata: ahci: Rename CONFIG_SATA_LPM_MOBILE_POLICY configuration item")
and
55b014159ee7 ("ata: ahci: Rename CONFIG_SATA_LPM_POLICY configuration item back")

so I also prefer to avoid renaming Kconfigs as far as possible.


Kind regards,
Niklas

  reply	other threads:[~2024-09-13  6:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-09 20:51 [PATCH] ata: ata_generic: use IS_ENABLED() macro Sergey Shtylyov
2024-09-10  4:50 ` Damien Le Moal
2024-09-10  8:52   ` Sergey Shtylyov
2024-09-10 13:09     ` Damien Le Moal
2024-09-10 14:32       ` Sergey Shtylyov
2024-09-10 14:36       ` Sergey Shtylyov
2024-09-10 22:22         ` Damien Le Moal
2024-09-11 17:14           ` Sergey Shtylyov
2024-09-13  6:57             ` Niklas Cassel [this message]
2024-09-13 19:36               ` Sergey Shtylyov
2024-09-14 17:53           ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuPiUWlcNmBt9tqH@ryzen.lan \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=s.shtylyov@omp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox