From: Andrew Morton <akpm@osdl.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: andi@rhlx01.fht-esslingen.de, B.Zolnierkiewicz@elka.pw.edu.pl,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] ide_end_drive_cmd(): avoid instruction pipeline stall
Date: Fri, 30 Jun 2006 11:00:18 -0700 [thread overview]
Message-ID: <20060630110018.f45b40e2.akpm@osdl.org> (raw)
In-Reply-To: <1151688416.31392.66.camel@localhost.localdomain>
On Fri, 30 Jun 2006 18:26:56 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Ar Gwe, 2006-06-30 am 18:13 +0200, ysgrifennodd Andreas Mohr:
> > Use an independently-formatted "unsigned int" for data instead of a
> > restrictive "u16" to avoid instruction fetch pipeline stalls
> > probably caused by the byte calculations later.
>
> drivers/ide is on its way out.
Like sound/oss ;)
> I'm also curious that this shows up given
> that the inw() is going to cause a PCI sequence and stall the CPU
> entirely for ages anyway.
I guess because he was profiling for IFU_MEM_STALL, not for wall-time.
> NAK because
> 1. This is a gcc problem
> 2. Not everyone is using an intel x86-32 box which has such problems
> 3. IDE is in life-support mode and the relatives are already planning
> the flowers.
Well. If the patch breaks anything we can dine on hats for a month. Seems
pretty inoffensive to me.
next prev parent reply other threads:[~2006-06-30 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-30 16:13 [PATCH -mm] ide_end_drive_cmd(): avoid instruction pipeline stall Andreas Mohr
2006-06-30 17:26 ` Alan Cox
2006-06-30 18:00 ` Andrew Morton [this message]
2006-06-30 18:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060630110018.f45b40e2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox